[asterisk-bugs] [JIRA] (ASTERISK-29895) chan_iax2: Fix misaligned spacing in iax2 show netstats printout

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=258180#comment-258180 ] 

Kevin Harwell edited comment on ASTERISK-29895 at 2/24/22 12:49 PM:
--------------------------------------------------------------------

Sorry, missed this the first time.

I have it patched on my systems right now, so I can only get the "after", but I've included an example of what the "before" would look like underneath as well:
https://paste.interlinked.us/drxhvo917w.txt
{noformat}
voip*CLI> iax2 show netstats
                                --------- LOCAL --------------------  --------- REMOTE -------------------
Channel                    RTT  Jit  Del  Lost   %  Drop  OOO  Kpkts  Jit  Del  Lost   %  Drop  OOO  Kpkts FirstMsg    LastMsg
IAX2/REDACTED0-rsa-wolfri 1000   -1    0    -1  -1     0   -1      0    0    0     0   0     0    0      0 Tx:NEW      Tx:ACK

voip*CLI> iax2 show netstats
                                --------- LOCAL --------------------  --------- REMOTE -------------------
Channel              RTT  Jit  Del  Lost   %  Drop  OOO  Kpkts  Jit  Del  Lost   %  Drop  OOO  Kpkts FirstMsg    LastMsg
IAX2/REDACTED0-rsa-wolfri 1000   -1    0    -1  -1     0   -1      0    0    0     0   0     0    0      0 Tx:NEW      Tx:ACK
{noformat}

Essentially, it was just shifted over a bit, in such a way that I looked at what seemed to be the "Jit" column and thought I was reading the jitter buffer time, but it was actually the RTT, the table wasn't formatted right and that misled me.

The formatting fix just forces everything to line up properly, 100% of the time.


was (Author: interlinked):
Sorry, missed this the first time.

I have it patched on my systems right now, so I can only get the "after", but I've included an example of what the "before" would look like underneath as well:
https://paste.interlinked.us/drxhvo917w.txt

Essentially, it was just shifted over a bit, in such a way that I looked at what seemed to be the "Jit" column and thought I was reading the jitter buffer time, but it was actually the RTT, the table wasn't formatted right and that misled me.

The formatting fix just forces everything to line up properly, 100% of the time.

> chan_iax2: Fix misaligned spacing in iax2 show netstats printout
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-29895
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29895
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_iax2
>    Affects Versions: 18.9.0
>            Reporter: N A
>            Assignee: N A
>
> If the channel name is long enough, the spacing for the printout gets screwed up and the headers are no longer referring to the proper columns. This adds a padding of 4 spaces to the header so that the columns are always correctly aligned.



--
This message was sent by Atlassian JIRA
(v6.2#6252)