[asterisk-bugs] [JIRA] (DAHLIN-396) RXMIRROR / TXMIRROR not working for HARD HDLC

[Harald Welte (JIRA)]

Harald Welte created DAHLIN-396:
-----------------------------------

             Summary: RXMIRROR / TXMIRROR not working for HARD HDLC
                 Key: DAHLIN-396
                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-396
             Project: DAHDI-Linux
          Issue Type: Bug
      Security Level: None
          Components: General
    Affects Versions: 3.1.0
            Reporter: Harald Welte
            Assignee: Duncan Patterson


RXMIRROR and TXMIRROR functionality works fine for DAHDI_SIG_HDLCRAW, DAHDI_SIG_HDLCFCS and DAHDI_SIG_HDLCNET, but it silently fails for DAHDI_SIG_HARDHDLC.

This means that if you use dahdi_pcap to generate a LAPD pcap ifle of a signaling channel in HARDHDLC mode, you will never receive any packets.  There is no error message.

This is due to the fact that the mirroring loginc is only integrated into the getbuf / putbuf code path, but not the dahdi_hdlc_* API used in the HARDHDLC case.

At the very least, I would expect the MIRROR ioctl to fail in case the underlying driver/hardware doesn't support mirroring.  But having the ioctl succeed while not actually capturing any packets is rather strange.

Ideally of course the mirroring logic would be implemented for HARDHDLC, as for BRI there is little choice, so no BRI LDAPD pcap files can be generated at all.



--
This message was sent by Atlassian JIRA
(v6.2#6252)