[asterisk-bugs] [JIRA] (ASTERISK-29912) res_pjsip: module reload disables logging

[Joshua C. Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-29912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua C. Colp updated ASTERISK-29912:
--------------------------------------

    Description: 
1. Start PJSIP pcap logging with 
pjsip set logger pcap filename
pjsip set logger verbose off
pjsip set logger on

2. module reload res_pjsip.so

3. pcap file no longer collects data

---
discussion from IRC
(09:48:33 AM) seanbright: res_pjsip_logger does not have a reload handler
(09:48:53 AM) seanbright: and i guess you're not reloading that anyway, so. /me shuts up for a second
(09:49:18 AM) file: it has a callback for if res_pjsip is reloaded, cause there's a global debug thing
(09:51:31 AM) seanbright: so that global handler seems to turn it off if [global] debug is not set?
(09:54:51 AM) seanbright: yeah, i think it's a bug. the ->enabled flag is never set in the pcap path
(09:55:00 AM) seanbright: but i will need to try and reproduce locally before i confirm that
(09:58:57 AM) file: yeah, I think I did that on purpose - cramming all of the instructions into a single CLI command was unwieldy, so thus multiple logger commands
(10:00:41 AM) seanbright: the unintuitive part is that a reload of res_pjsip would affect res_pjsip_logger
(10:00:58 AM) seanbright: esp. if the type=global,debug option isn't touched


  was:
1. Start PJSIP pcap logging with 
pjsip set logger pcap filename
pjsip set logger verbose off

2. module reload res_pjsip.so

3. pcap file no longer collects data

---
discussion from IRC
(09:48:33 AM) seanbright: res_pjsip_logger does not have a reload handler
(09:48:53 AM) seanbright: and i guess you're not reloading that anyway, so. /me shuts up for a second
(09:49:18 AM) file: it has a callback for if res_pjsip is reloaded, cause there's a global debug thing
(09:51:31 AM) seanbright: so that global handler seems to turn it off if [global] debug is not set?
(09:54:51 AM) seanbright: yeah, i think it's a bug. the ->enabled flag is never set in the pcap path
(09:55:00 AM) seanbright: but i will need to try and reproduce locally before i confirm that
(09:58:57 AM) file: yeah, I think I did that on purpose - cramming all of the instructions into a single CLI command was unwieldy, so thus multiple logger commands
(10:00:41 AM) seanbright: the unintuitive part is that a reload of res_pjsip would affect res_pjsip_logger
(10:00:58 AM) seanbright: esp. if the type=global,debug option isn't touched



> res_pjsip: module reload disables logging
> -----------------------------------------
>
>                 Key: ASTERISK-29912
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29912
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 18.8.0
>            Reporter: Mitch Claborn
>
> 1. Start PJSIP pcap logging with 
> pjsip set logger pcap filename
> pjsip set logger verbose off
> pjsip set logger on
> 2. module reload res_pjsip.so
> 3. pcap file no longer collects data
> ---
> discussion from IRC
> (09:48:33 AM) seanbright: res_pjsip_logger does not have a reload handler
> (09:48:53 AM) seanbright: and i guess you're not reloading that anyway, so. /me shuts up for a second
> (09:49:18 AM) file: it has a callback for if res_pjsip is reloaded, cause there's a global debug thing
> (09:51:31 AM) seanbright: so that global handler seems to turn it off if [global] debug is not set?
> (09:54:51 AM) seanbright: yeah, i think it's a bug. the ->enabled flag is never set in the pcap path
> (09:55:00 AM) seanbright: but i will need to try and reproduce locally before i confirm that
> (09:58:57 AM) file: yeah, I think I did that on purpose - cramming all of the instructions into a single CLI command was unwieldy, so thus multiple logger commands
> (10:00:41 AM) seanbright: the unintuitive part is that a reload of res_pjsip would affect res_pjsip_logger
> (10:00:58 AM) seanbright: esp. if the type=global,debug option isn't touched



--
This message was sent by Atlassian JIRA
(v6.2#6252)