[asterisk-bugs] [JIRA] (DAHTOOL-91) configuration option for DAHLIN-395

[N A (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHTOOL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=257964#comment-257964 ] 

N A commented on DAHTOOL-91:
----------------------------

I'm not sure to what extent the Asterisk style guidelines apply here, but a couple of things to note perhaps:

1) Use { } around if blocks, even when not necessary. Older code doesn't do that, but it's required for Asterisk additions now in new code and that may be a DAHDI policy as well.

2) Spaces are needed around the = and ; operators in for (x=0;x<DAHDI_MAX_CHANNELS;x++) {, per the style guidelines.

Again, these are the Asterisk guidelines, but may apply to DAHDI as well; just thought I'd point that out.

> configuration option for DAHLIN-395
> -----------------------------------
>
>                 Key: DAHTOOL-91
>                 URL: https://issues.asterisk.org/jira/browse/DAHTOOL-91
>             Project: DAHDI-Tools
>          Issue Type: New Feature
>      Security Level: None
>          Components: NewFeature
>    Affects Versions: 3.1.0
>         Environment: N/A
>            Reporter: Sarah Autumn
>            Assignee: Duncan Patterson
>              Labels: patch
>         Attachments: DAHTOOL-91-hearpulsing.patch
>
>
> This configuration option is coupled with issue DAHLIN-395 and will allow callers to select channels to hear audio during call setup. This configuration is done in system.conf
> Also see https://gerrit.asterisk.org/c/asterisk/+/17948



--
This message was sent by Atlassian JIRA
(v6.2#6252)