[asterisk-bugs] [JIRA] (ASTERISK-29943) file.c: seeking to negative file offset is not prevented

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=258956#comment-258956 ] 

Friendly Automation commented on ASTERISK-29943:
------------------------------------------------

Change 18354 merged by Friendly Automation:
file.c: Prevent formats from seeking negative offsets.

[https://gerrit.asterisk.org/c/asterisk/+/18354|https://gerrit.asterisk.org/c/asterisk/+/18354]

> file.c: seeking to negative file offset is not prevented
> --------------------------------------------------------
>
>                 Key: ASTERISK-29943
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29943
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/FileFormatInterface
>    Affects Versions: 18.9.0
>            Reporter: N A
>            Assignee: N A
>
> If you use ControlPlayback to rewind past the beginning of an audio file, in this case with ulaw files, you'll see warnings like this:
> [2022-03-01 00:57:56] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:57:56] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237760, resetting to 0
> [2022-03-01 00:57:56] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:57:57] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -231840, resetting to 0
> [2022-03-01 00:57:58] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237760, resetting to 0
> [2022-03-01 00:57:58] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:57:59] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -232160, resetting to 0
> [2022-03-01 00:57:59] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:58:00] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:58:01] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -232160, resetting to 0
> [2022-03-01 00:58:01] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:58:01] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237600, resetting to 0
> [2022-03-01 00:58:01] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237760, resetting to 0
> [2022-03-01 00:58:02] WARNING[1612][C-00000026]: format_pcm.c:134 pcm_seek: negative offset -237440, resetting to 0
> This shouldn't be throwing warnings, because a user rewinding a recording to the beginning is a perfectly legitimate thing to attempt.
> Two possible options are:
> 1) Have the file formats not throw warnings for this (but debugs instead), if there is no actual circumstance in which this would be a cause for concern
> 2) Catch this possibility in the ast core rewind function and set a floor of 0 for the offset to seek, preventing asking the file format for a negative seek time to begin with.
> A patch for possible option #2 is enclosed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)