[asterisk-bugs] [JIRA] (ASTERISK-30021) ast_variable_list_replace_variable uses variable with new keyword

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-30021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=258880#comment-258880 ] 

Friendly Automation commented on ASTERISK-30021:
------------------------------------------------

Change 18399 merged by Friendly Automation:
config.h: Don't use C++ keywords as argument names.

[https://gerrit.asterisk.org/c/asterisk/+/18399|https://gerrit.asterisk.org/c/asterisk/+/18399]

> ast_variable_list_replace_variable uses variable with new keyword
> -----------------------------------------------------------------
>
>                 Key: ASTERISK-30021
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-30021
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_vpb
>    Affects Versions: 18.11.0
>            Reporter: Jasper Hafkenscheid
>            Assignee: Sean Bright
>
> The newly introduced ast_variable_list_replace_variable method in config.c uses the C++ {{new}} keyword as an argument. 
> {noformat}
> int ast_variable_list_replace_variable(struct ast_variable **head, struct ast_variable *old,
> 	struct ast_variable *new);
> {noformat}
> This file is also included in C++ source, causing a compilation error such as:
> {noformat}
> In file included from /build/asterisk-18.11.2/include/asterisk/channel.h:178,
>                  from chan_vpb.cc:66:
> /build/asterisk-18.11.2/include/asterisk/config.h:985:23: error: expected ',' or '...' before 'new'
>   struct ast_variable *new);
>                        ^~~
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)