[asterisk-bugs] [JIRA] (ASTERISK-29704) PJSIP treats SUBSCRIBE with Expires 0 as invalid

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256680#comment-256680 ] 

Asterisk Team commented on ASTERISK-29704:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

> PJSIP treats SUBSCRIBE with Expires 0 as invalid
> ------------------------------------------------
>
>                 Key: ASTERISK-29704
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29704
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_pubsub
>    Affects Versions: 18.7.1
>         Environment: Debian Linux 10
>            Reporter: Niksa Baldun
>
> When res_pjsip receives SUBSCRIBE request with Expires=0, it responds with with 400 Bad request. Excerpt from res_pjsip_pubsub.c:
> {code}
>         if (expires_header->ivalue == 0) { 
>             ast_debug(1, "Subscription request from endpoint %s rejected. Expiration of 0 is invalid\n",
>                 ast_sorcery_object_get_id(endpoint));
>             pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 400, NULL, NULL, NULL);
>                 return PJ_TRUE;
>         }
> {code}
> However, Expires of 0 is perfectly valid. Relevant text from RFC 3265, section 3.1.1:
> {quote}
>    A natural consequence of this scheme is that a SUBSCRIBE with an
>    "Expires" of 0 constitutes a request to unsubscribe from an event.
>       In addition to being a request to unsubscribe, a SUBSCRIBE message
>       with "Expires" of 0 also causes a fetch of state; see section
>       3.3.6.
> {quote}
> Therefore, a SUBSCRIBE with Expires=0 should cause one NOTIFY to be sent, and remove the subscription if it exists.



--
This message was sent by Atlassian JIRA
(v6.2#6252)