[asterisk-bugs] [JIRA] (DAHTOOL-88) dahdi-tools, -Werror in xpp/oct612x/Makefile

[Keith Morgan (JIRA)]

     [ https://issues.asterisk.org/jira/browse/DAHTOOL-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Morgan updated DAHTOOL-88:
--------------------------------

    Assignee: Duncan Patterson  (was: Keith Morgan)

> dahdi-tools, -Werror in xpp/oct612x/Makefile
> --------------------------------------------
>
>                 Key: DAHTOOL-88
>                 URL: https://issues.asterisk.org/jira/browse/DAHTOOL-88
>             Project: DAHDI-Tools
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 3.1.0
>         Environment: Gentoo Linux.
>            Reporter: Jaco Kroon
>            Assignee: Duncan Patterson
>            Severity: Trivial
>
> https://bugs.gentoo.org/751850
> I'd recommend the -Werror only be added via DAHDI_DEVMODE_TRUE ...
> xpp/oct612x/Makefile:391
> GLOBAL_CFLAGS = -Wall -Werror
> To be changed to take the value of DAHDI_DEVMODE into consideration, thus in Makefile.am, update the first line to:
> GLOBAL_CFLAGS = -Wall
> @DAHDI_DEVMODE_TRUE at GLOBAL_CFLAGS += -Werror
> Alternatively, follow the same patterns as the top level Makefile which makes use of an append structure for same.
> I'm certain other fixes are possible too, and I'm not sure what your preferred solution would be in this case.



--
This message was sent by Atlassian JIRA
(v6.2#6252)