[asterisk-bugs] [JIRA] (ASTERISK-29728) menuselect: Disabled by default modules that are enabled are always recompiled

[Sean Bright (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256823#comment-256823 ] 

Sean Bright edited comment on ASTERISK-29728 at 11/9/21 8:51 AM:
-----------------------------------------------------------------

{noformat}
20:46 <@seanbright> it's menuselect related, that much i've been able to find out so far
20:47 < InterLinked> Ah, strictly menuselect, not in the makefile?
20:47 <@seanbright> when 'menuselect --check-deps menuselect.makeopts' runs it runs the delete_on_change files for defaultenabled=no modules
20:47 <@seanbright> correct, menuselect
20:47 < InterLinked> any obvious reason why it's doing that, or would it be fine to patch that?
20:48 <@seanbright> it's not obvious to me or there would already be a review up for it
20:48 <@seanbright> patch away
20:48 < InterLinked> Thanks, I'll play with it and see it then
20:48 <@seanbright> you're welcome
20:52 < InterLinked> Wait, where did you find the delete_on_change? I can't find anything at all in the tree for that
20:52 <@seanbright> remove_on_change maybe
20:59 < InterLinked> yeah, that's it. How is the debugging in menuselect used? I don't see any documentation for it in the wiki or the README. I see you can do make menuselect -d and get debug output for menuselect, but it compiles it when I run "make 
                     install" (or what have you), so I want to debug that. Do I need to alter the makefile?
20:59 <@seanbright> not sure
21:19 <@seanbright> i think parse_existing_config() and mark_as_present() are wrong
21:19 <@seanbright> MENUSELECT_APPS in menuselect.makeopts is a list of mdules that are _not_ selected
21:19 <@seanbright> so you would want to iterate all available modules and select/deselect them
21:20 <@seanbright> not just the ones listed in the .makeopts file
21:31 <@seanbright> mem->enabled = (negate ? !cat->positive_output : cat->positive_output);
21:31  * seanbright 's head explodes
{noformat}


was (Author: seanbright):
{noformat}
21:19 <@seanbright> i think parse_existing_config() and mark_as_present() are wrong
21:19 <@seanbright> MENUSELECT_APPS in menuselect.makeopts is a list of mdules that are _not_ selected
21:19 <@seanbright> so you would want to iterate all available modules and select/deselect them
21:20 <@seanbright> not just the ones listed in the .makeopts file
21:31 <@seanbright> mem->enabled = (negate ? !cat->positive_output : cat->positive_output);
21:31  * seanbright 's head explodes
{noformat}

> menuselect: Disabled by default modules that are enabled are always recompiled
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-29728
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29728
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 18.8.0
>            Reporter: N A
>            Severity: Trivial
>
> <defaultenabled>no</defaultenabled> can be added to a module so that it is not compiled by default.
> However, when this happens, any time anything changes in Asterisk source and make / make install is used to recompile, any enabled (but disabled by default) modules will ALWAYS be recompiled.
> This is mostly frustrating in the dev process, but there appears to be some logic wrong with menuselect here that seems to be causing this.
> I'm just reporting this for now, so probably best to leave it open rather than assigning it to me.



--
This message was sent by Atlassian JIRA
(v6.2#6252)