[asterisk-bugs] [JIRA] (ASTERISK-29373) res_rtp_asterisk: Flash events are duplicated

[N A (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254378#comment-254378 ] 

N A commented on ASTERISK-29373:
--------------------------------

Thanks, Joshua, clearly I need to read "AMI For Dummies" and figure out how it works! I was trying to find an easy way to view AMI events in the console so I can test when my Flash event works.

Your patch works as far as I can tell when I tested it. I commented out my FLASH_END stuff and overwrote my res_rtp with the original and then patched it and I see one event each time. Would you be able to mark your patch as the resolution to this issue? Your patch fixes this issue perfectly. I will submit my patches for AMI support in a new feature issue since that is not related to this one.

> res_rtp_asterisk: Flash events are duplicated
> ---------------------------------------------
>
>                 Key: ASTERISK-29373
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29373
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 18.3.0
>         Environment: Debian 10
>            Reporter: N A
>            Assignee: Unassigned
>              Labels: patch
>         Attachments: ASTERISK-29373.diff, res_rtp_asterisk.patch
>
>
> I noticed that for RFC2833 hook flash events, they were all getting duplicated. I found this is due to the way RFC2833 events work, where there is a start and end for each event. However, unlike DTMF events, for which there are beginning and end events, Asterisk has no notion of the beginning or end of a hook flash - there is only one hook flash (AST_CONTROL_FLASH). Thus, incoming RTP packets create duplicate flash events, which channel.c is not expecting. The attached patch fixes this bug by ensuring that only flash starts become AST_CONTROL_FLASH and flash end events are not duplicated, thus aligning what res_rtp_asterisk.c is doing with what channel.c expects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)