[asterisk-bugs] [JIRA] (ASTERISK-29373) res_rtp_asterisk: Flash events are duplicated

[N A (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254376#comment-254376 ] 

N A commented on ASTERISK-29373:
--------------------------------

Your patch is certainly different from mine. For the most part, I tried ignoring the end event, not the beginning event. I tried it once hte other way and the end event did not seem to work if the beginning the event was not there (i.e. the end became the beginning and then they were both ignored - so wrong the other way). I'll try your patch on my other system and see what happens. Assuming it works, then I'll cancel this particular patch - I don't want to rock the boat unnecessarily.

As far as the manager event goes, even doing "manager show event <name>" does not work, even if the event is explicitly named. So it seems that the manager CLI does not allow for checking events individually if they do not show up in the summary list. Is there actually a way to use these events, or is this unintended? I can file a separate bug issue for that if that's what it is.

> res_rtp_asterisk: Flash events are duplicated
> ---------------------------------------------
>
>                 Key: ASTERISK-29373
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29373
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 18.3.0
>         Environment: Debian 10
>            Reporter: N A
>            Assignee: Unassigned
>              Labels: patch
>         Attachments: ASTERISK-29373.diff, res_rtp_asterisk.patch
>
>
> I noticed that for RFC2833 hook flash events, they were all getting duplicated. I found this is due to the way RFC2833 events work, where there is a start and end for each event. However, unlike DTMF events, for which there are beginning and end events, Asterisk has no notion of the beginning or end of a hook flash - there is only one hook flash (AST_CONTROL_FLASH). Thus, incoming RTP packets create duplicate flash events, which channel.c is not expecting. The attached patch fixes this bug by ensuring that only flash starts become AST_CONTROL_FLASH and flash end events are not duplicated, thus aligning what res_rtp_asterisk.c is doing with what channel.c expects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)