[asterisk-bugs] [JIRA] (ASTERISK-29373) res_rtp_asterisk: Flash events are duplicated

[Joshua C. Colp (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254374#comment-254374 ] 

Joshua C. Colp edited comment on ASTERISK-29373 at 3/29/21 3:50 PM:
--------------------------------------------------------------------

It's most likely the change you did was incorrect in res_rtp_asterisk or incomplete. For merging purposes I would strongly prefer that, as it touches far less things. You're free to attach your current approach once the license agreement is processed, but others may feel the same way if you put it up for code review for inclusion. As for why the simpler approach didn't work - without a backtrace it is anyone's guess.

"manager show events" outputs based on the XML documentation. The XML documentation for the given events does not appear sufficient to place them in the XML documentation file, resulting in them not showing in "manager show events". I don't believe there's any issue filed for it.


was (Author: jcolp):
It's most likely the change you did was incorrect in res_rtp_asterisk or incomplete. For merging purposes I would strongly prefer that, as it touches far less things. You're free to attach your approach once the license agreement is processed, but others may feel the same way if you put it up for code review for inclusion. As for why the simpler approach didn't work - without a backtrace it is anyone's guess.

"manager show events" outputs based on the XML documentation. The XML documentation for the given events does not appear sufficient to place them in the XML documentation file, resulting in them not showing in "manager show events". I don't believe there's any issue filed for it.

> res_rtp_asterisk: Flash events are duplicated
> ---------------------------------------------
>
>                 Key: ASTERISK-29373
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29373
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 18.3.0
>         Environment: Debian 10
>            Reporter: N A
>            Assignee: Unassigned
>              Labels: patch
>         Attachments: res_rtp_asterisk.patch
>
>
> I noticed that for RFC2833 hook flash events, they were all getting duplicated. I found this is due to the way RFC2833 events work, where there is a start and end for each event. However, unlike DTMF events, for which there are beginning and end events, Asterisk has no notion of the beginning or end of a hook flash - there is only one hook flash (AST_CONTROL_FLASH). Thus, incoming RTP packets create duplicate flash events, which channel.c is not expecting. The attached patch fixes this bug by ensuring that only flash starts become AST_CONTROL_FLASH and flash end events are not duplicated, thus aligning what res_rtp_asterisk.c is doing with what channel.c expects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)