[asterisk-bugs] [JIRA] (ASTERISK-29373) RTP flash events are duplicated improperly

[N A (JIRA)]

N A created ASTERISK-29373:
------------------------------

             Summary: RTP flash events are duplicated improperly
                 Key: ASTERISK-29373
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29373
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_rtp_asterisk
    Affects Versions: 18.3.0
         Environment: Debian 10
            Reporter: N A
            Severity: Major


I noticed that for RFC2833 hook flash events, they were all getting duplicated. I found this is due to the way RFC2833 events work, where there is a start and end for each event. However, unlike DTMF events, for which there are beginning and end events, Asterisk has no notion of the beginning or end of a hook flash - there is only one hook flash (AST_CONTROL_FLASH). Thus, incoming RTP packets create duplicate flash events, which channel.c is not expecting. The attached patch fixes this bug by ensuring that only flash starts become AST_CONTROL_FLASH and flash end events are not duplicated, thus aligning what res_rtp_asterisk.c is doing with what channel.c expects.



--
This message was sent by Atlassian JIRA
(v6.2#6252)