[asterisk-bugs] [JIRA] (ASTERISK-28890) res_pjsip_sdp_rtp: Keepalive not supported for video streams

[Luke Escude (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Escude updated ASTERISK-28890:
-----------------------------------

    Attachment: video_nat.patch

Hey folks, here's the official patch file - This works as of Asterisk 16.14

I will read up on the gerrit process and attempt to submit it officially.

To recap, this fixes keepalives for video calls. Keepalives work just fine for audio, but they don't exist for video, which isn't ideal if you need Asterisk to punch through NAT like we do (all our PBX systems are behind their own NAT, and all customer endpoints are behind NAT).

> res_pjsip_sdp_rtp: Keepalive not supported for video streams
> ------------------------------------------------------------
>
>                 Key: ASTERISK-28890
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28890
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_pjsip_sdp_rtp
>    Affects Versions: 17.4.0
>            Reporter: Luke Escude
>              Labels: patch
>         Attachments: video_nat.patch
>
>
> So I've noticed that RTP Keepalives work just fine for audio, but they don't function for video.
> Here are the changes needed to be made for keepalive packets to function for video:
> In res/res_pjsip_sdp_rtp.c:
> Change the following (Line 2032):
> if (media_type != AST_MEDIA_TYPE_AUDIO) {
> to: if (media_type != AST_MEDIA_TYPE_AUDIO && media_type != AST_MEDIA_TYPE_VIDEO) {
> ALSO
> Change the following (Line 2061):
> if (session->endpoint->media.rtp.keepalive > 0 &&
> 			session_media->type == AST_MEDIA_TYPE_AUDIO) {
> to
> if (session->endpoint->media.rtp.keepalive > 0 &&
> 			(session_media->type == AST_MEDIA_TYPE_AUDIO || session_media->type == AST_MEDIA_TYPE_VIDEO)) {
> Sorry guys, I don't know how to make a patch... But these 2 line changes will fix dysfunctional keepalives for video.



--
This message was sent by Atlassian JIRA
(v6.2#6252)