[asterisk-bugs] [JIRA] (ASTERISK-28890) res_pjsip_sdp_rtp: Keepalive not supported for video streams

[Luke Escude (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255472#comment-255472 ] 

Luke Escude commented on ASTERISK-28890:
----------------------------------------

Do you guys think this patch could make it into a release soon?

> res_pjsip_sdp_rtp: Keepalive not supported for video streams
> ------------------------------------------------------------
>
>                 Key: ASTERISK-28890
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28890
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_pjsip_sdp_rtp
>    Affects Versions: 17.4.0
>            Reporter: Luke Escude
>
> So I've noticed that RTP Keepalives work just fine for audio, but they don't function for video.
> Here are the changes needed to be made for keepalive packets to function for video:
> In res/res_pjsip_sdp_rtp.c:
> Change the following (Line 2032):
> if (media_type != AST_MEDIA_TYPE_AUDIO) {
> to: if (media_type != AST_MEDIA_TYPE_AUDIO && media_type != AST_MEDIA_TYPE_VIDEO) {
> ALSO
> Change the following (Line 2061):
> if (session->endpoint->media.rtp.keepalive > 0 &&
> 			session_media->type == AST_MEDIA_TYPE_AUDIO) {
> to
> if (session->endpoint->media.rtp.keepalive > 0 &&
> 			(session_media->type == AST_MEDIA_TYPE_AUDIO || session_media->type == AST_MEDIA_TYPE_VIDEO)) {
> Sorry guys, I don't know how to make a patch... But these 2 line changes will fix dysfunctional keepalives for video.



--
This message was sent by Atlassian JIRA
(v6.2#6252)