[asterisk-bugs] [JIRA] (ASTERISK-29464) ARI - PlaybackFinish skip error events

[Andre Barbosa (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-29464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Barbosa updated ASTERISK-29464:
-------------------------------------

    Description: 
This one is related with https://issues.asterisk.org/jira/browse/ASTERISK-29463

When we try to play a list of sound files in the same Play command, we get only one PlaybackFinish event, after all sounds are played.

But in the case where the Play fails (because channel is destroyed for example), Asterisk will send one PlaybackFinish event for each sound file still to be played.  If the list is big, Asterisk is sending lot of events.

This patch adds STASIS_PLAYBACK_STATE_ERROR state (https://issues.asterisk.org/jira/browse/ASTERISK-29463 please) so we can understand that the play failed. On that case we don't send the event, if we still have a list of sounds to be played.

When we reach the last sound, we fired the PlaybackFinish with the error state.


 

  was:
This one is related with https://issues.asterisk.org/jira/browse/ASTERISK-29463

When we try to play a list of sound files in the same Play command, we get only one PlaybackFinish event, after all sounds are played.

But in the case where the play fails (because channel is destroyed for example), Asterisk will send one PlaybackFinish event for each sound file still to be played. If the list is big, Asterisk is sending lot of events.

With this patch with STASIS_PLAYBACK_STATE_ERROR state (https://issues.asterisk.org/jira/browse/ASTERISK-29463 please), we understand that the play failed and we don't send the event if we still have a list of sounds to play.

When we reach the last sound, we fired the PlaybackFinish with the error state.


 


> ARI - PlaybackFinish skip error events
> --------------------------------------
>
>                 Key: ASTERISK-29464
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29464
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Resources/res_stasis_playback
>    Affects Versions: 18.4.0
>            Reporter: Andre Barbosa
>              Labels: patch
>         Attachments: playback_finish_error_state.diff
>
>
> This one is related with https://issues.asterisk.org/jira/browse/ASTERISK-29463
> When we try to play a list of sound files in the same Play command, we get only one PlaybackFinish event, after all sounds are played.
> But in the case where the Play fails (because channel is destroyed for example), Asterisk will send one PlaybackFinish event for each sound file still to be played.  If the list is big, Asterisk is sending lot of events.
> This patch adds STASIS_PLAYBACK_STATE_ERROR state (https://issues.asterisk.org/jira/browse/ASTERISK-29463 please) so we can understand that the play failed. On that case we don't send the event, if we still have a list of sounds to be played.
> When we reach the last sound, we fired the PlaybackFinish with the error state.
>  



--
This message was sent by Atlassian JIRA
(v6.2#6252)