[asterisk-bugs] [JIRA] (ASTERISK-29263) PJSIP

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253603#comment-253603 ] 

Asterisk Team commented on ASTERISK-29263:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. Please note that log messages and other files should not be sent to the Sangoma Asterisk Team unless explicitly asked for. All files should be placed on this issue in a sanitized fashion as needed.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

Please note that by submitting data, code, or documentation to Sangoma through JIRA, you accept the Terms of Use present at [https://www.asterisk.org/terms-of-use/|https://www.asterisk.org/terms-of-use/].

> PJSIP 
> ------
>
>                 Key: ASTERISK-29263
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29263
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: pjproject/pjsip
>    Affects Versions: 16.15.0
>         Environment: debian x64
>            Reporter: Flamur Dervishi
>            Severity: Minor
>
> We were experiencing a strange behaviour with the device state when using 'devicestate_busy_at' option.
> With 'devicestate_busy_at' set to 2, after an endpoint would receive 2 calls, its device state would be set to 'Busy'. However when a 3rd call is in play, the device state changed to 'In use', when it still needs to be 'Busy' in respect of 'devicestate_busy_at' value.
> After some investigation in the 'chan_pjsip.c' file, in the function 'chan_pjsip_devicestate' we noticed that the condition to check  if the 'devicestate_busy_at' is reached is wrong.
> static int chan_pjsip_devicestate(const char *data)
> {
> 	...
> 	if (endpoint->devicestate_busy_at && (inuse == endpoint->devicestate_busy_at)) {
> 		state = AST_DEVICE_BUSY;
> 	} else if (ast_devstate_aggregate_result(&aggregate) != AST_DEVICE_INVALID) {
> 		state = ast_devstate_aggregate_result(&aggregate);
> 	}
> 	...
> }
> Should be:
> static int chan_pjsip_devicestate(const char *data)
> {
> 	...
> 	if (endpoint->devicestate_busy_at && (inuse >= endpoint->devicestate_busy_at)) {
> 		state = AST_DEVICE_BUSY;
> 	} else if (ast_devstate_aggregate_result(&aggregate) != AST_DEVICE_INVALID) {
> 		state = ast_devstate_aggregate_result(&aggregate);
> 	}
> 	...
> } 
> Meaning, the device state will be 'Busy' when the 'devicestate_busy_at' is reached or exceeded, and not only when it is equal to 'devicestate_busy_at' value



--
This message was sent by Atlassian JIRA
(v6.2#6252)