[asterisk-bugs] [JIRA] (ASTERISK-29603) res_pjsip: UPDATE/re-INVITE not sent when "timers=always" is specified in pjsip.conf

[Ray Crumrine (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255931#comment-255931 ] 

Ray Crumrine edited comment on ASTERISK-29603 at 8/18/21 8:29 AM:
------------------------------------------------------------------

I discovered today after some simple testing that setting the *PJSIP_INV_SUPPORT_TIMER* flag *may* not be necessary for the "timers=required" option. Operation  *appears* to be normal without setting that bit. No negative effects were observed. I was unable to find any documentation on pjlib Git that stated one way or the other.
*edited 8/18* After further consideration and review, I am almost 100% certain that modification of the "required" line is not necessary and should not be changed. Per a note from Git pjlib and further perusal of the current timers_handler code, the following looks to be true;
timers=no -> = pjlib "use-timer=0" -> both bit 0 and 1 *off*
timers=yes -> = "use-timer=1" -> bit 0 *on*
timers=required -> = "use-timer=2" -> bit 1 *on*
timers=always -> = "use-timer=3" -> both bit 0 and 1 *on*
I have deleted the line in the note shown above. Sorry for any confusion.


was (Author: proftech):
I discovered today after some simple testing that setting the *PJSIP_INV_SUPPORT_TIMER* flag *may* not be necessary for the "timers=required" option. Operation  *appears* to be normal without setting that bit. No negative effects were observed. I was unable to find any documentation on pjlib Git that stated one way or the other.
*edited 8/18* After further consideration and review, I am almost 100% certain that modification of the "required" line is not necessary and should not be changed. Per a note from Git pjlib and further perusal of the current timers_handler code, the following looks to be true;
timers=no -> = [pjlib] timers-set=0 [both bit 0 and 1 *off*]
timers=yes -> = [pjlib] timers-set=1 [bit 0 *on*]
timers=required -> = [pjlib] timers-set=2 [bit 1 *on*]
timers=always -> = [pjlib] timers-set=3 [both bit 0 and 1 *on*]
I have deleted the line in the note shown above. Sorry for any confusion.

> res_pjsip: UPDATE/re-INVITE not sent when "timers=always" is specified in pjsip.conf
> ------------------------------------------------------------------------------------
>
>                 Key: ASTERISK-29603
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29603
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip
>    Affects Versions: 16.8.0
>         Environment: Debian 10.4
>            Reporter: Ray Crumrine
>            Severity: Major
>
> When using pjsip.conf option "timers=always", asterisk function "timers_handler" does not set complete flag information before calling pjsip and as a result pjsip does not go into the uac mode and does not send sip UPDATES or re-INVITES.
> -The "required" state needs flag settings (PJSIP_INV_REQUIRE_TIMER | PJSIP_INV_SUPPORT_TIMER)-
> the "always" state needs flag settings (PJSIP_INV_ALWAYS_USE_TIMER | PJSIP_INV_SUPPORT_TIMER)



--
This message was sent by Atlassian JIRA
(v6.2#6252)