[asterisk-bugs] [JIRA] (ASTERISK-29349) Silent voicemail option is not completely silent

Kevin Harwell (JIRA) noreply at issues.asterisk.org
Thu Apr 15 16:36:57 CDT 2021


    [ https://issues.asterisk.org/jira/browse/ASTERISK-29349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254607#comment-254607 ] 

Kevin Harwell commented on ASTERISK-29349:
------------------------------------------

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]
* As this is a new feature, please read the New Feature Guidelines [5]
* Make sure your new feature applies cleanly to Asterisk trunk

When ready, submit your patch and any tests to Gerrit [6] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/New+Feature+Guidelines
[6] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage



> Silent voicemail option is not completely silent
> ------------------------------------------------
>
>                 Key: ASTERISK-29349
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29349
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 18.2.0
>         Environment: Debian 10
>            Reporter: N A
>              Labels: patch
>         Attachments: ASTERISK-29349.patch
>
>
> I don't think this is necessarily a bug, but it is a drawback or caveat of the VoiceMail() application which, in my opinion, is non-sensical behavior.
> I play my own audio files before going to the VoiceMail() application in Asterisk. This includes using custom beep tones as opposed to the default beep file that is provided. My problem is that the s option (skip instructions) does not suppress the beep. As a result, the workaround I have been using for several years is now to replace beep.ulaw with a short, silent audio file, so that callers do not hear two beeps. This is demonstrated below:
> [Mar 16 12:48:11]     -- Executing [2311131 at tad:6] VoiceMail("Local/2311131 at tad-000022cd;2", "2311131 at default,s") in new stack
> [Mar 16 12:48:11]     -- <Local/2311131 at tad-000022cd;2> Playing 'beep.ulaw' (language 'en')
> [Mar 16 12:48:12]     -- Recording the message
> [Mar 16 12:48:12]     -- x=0, open writing:  /var/spool/asterisk/voicemail/default/2311131/tmp/MITIHK format: wav49, 0x7f7ae020be00
> [Mar 16 12:48:12]     -- x=1, open writing:  /var/spool/asterisk/voicemail/default/2311131/tmp/MITIHK format: gsm, 0x7f7ae01a0d20
> [Mar 16 12:48:12]     -- x=2, open writing:  /var/spool/asterisk/voicemail/default/2311131/tmp/MITIHK format: wav, 0x7f7ae0250e90
> I have a global variable called ${beep} I can use if I want to play an actual beep.
> The problem here arises if I want to use the VoiceMail application more as it is intended, not with the s option. In that case, I cannot simply play my own beep beforehand, but rely on the built in one, which I have overwritten. This is to say, you either have to provide your own beep files all the time or can't use custom beep files at all. For most people, I agree this will be a minor issue, if one at all, but it is such a simple issue to fix that it makes no sense for this drawback to persist.
> To rectify this issue, I would propose either:
> - modifying the s option to suppress the beep, because you can manually play a beep in the dialplan beforehand if you want to. The downside is this is not backwards-compatible with existing behavior. I don't seriously believe this option would be considered.
> - adding an additional option which, in addition to the s option, perhaps, would suppress the built in beep. That way, once can truly "silently" go into the voicemail application, and this option can be used when desired. For instance, a "q" option, for true silent/quiet operation.
> I believe an additional quiet option is warranted in this case; I could patch the application code to not play the beep, but the beep would be desirable some of the time, so an option to selectively disable this would be very useful. This grants administrators much more flexibility in voicemail configuration and would make voicemail in the dialplan less clumsy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list