[asterisk-bugs] [JIRA] (ASTERISK-29372) file.c switch does not account for flash events

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254431#comment-254431 ] 

Kevin Harwell commented on ASTERISK-29372:
------------------------------------------

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Gerrit [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage



> file.c switch does not account for flash events
> -----------------------------------------------
>
>                 Key: ASTERISK-29372
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29372
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 18.3.0
>         Environment: Debian 10
>            Reporter: N A
>            Assignee: Unassigned
>              Labels: patch
>         Attachments: file.patch, res_rtp_asterisk.patch
>
>
> There is a switch statement in file.c. that does not include AST_CONTROL_FLASH. As a result, anytime there is an RTP flash event, there is a WARNING printed to the console. This should be ignored in file.c; the attached patch simply adds AST_CONTROL_FLASH to the switch statement as a case so that it gets ignored properly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)