[asterisk-bugs] [JIRA] (DAHLIN-379) Dahdi-Linux 3.1.0 cannot compile against Kernel 5.4.x

[Harald Welte (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=252000#comment-252000 ] 

Harald Welte commented on DAHLIN-379:
-------------------------------------

I was not aware of the 'next' branch, so I just wasted hours replicating work that had already done.  To be honest, I find it quite confusing that the "head" of development is not in "master" but hidden in some other branch.  I literally work with hundreds of FOSS projects, and everyone else seems to have their commits of the day in "master".

Furthermore, Kernel 5.4 is hardly "next". It was released 10 months ago.

Finally, there is *zero* contribution guideline / informatoin for DAHDI.  I could only find it for Asterisk, and that points to gerrit.  However, the gerrit instance doesn't have the dahdi-linux repository created.  So clearly, the Asterisk contribution guidelines don't apply to DAHDI.  In lack of other information, I created a pull request.

To be honest, The last two weeks of my work with DAHDI have already convinced me of its serious lack of maintenance by Digium.  If somebody maintains a large/popular series of out-of-tree drivers,  I would expect that they keep track of mainline releases in a timely manner.

One can also clearly see that there are a number of dahdi_config.h compile options that haven't even been build-tested for years.  Luckily technology has advance and it's not the 90ies anymore - it's very easy to automatize this by some form of CI matrix build job that builds on any number of different kernel versions with any number of different #defines / Kconfigs.

It's fine if Digium/Sangoma don't have the commercial capacity to do so (given the pricing of their cards one would expect otherwise).  But then they should at least be open about it and put it under some kind of community/collaborative maintenance rather than ignoring contributed patches over extended periods of time (see the various DAHDI_NET fixes in this tracker).

> Dahdi-Linux 3.1.0 cannot compile against Kernel 5.4.x
> -----------------------------------------------------
>
>                 Key: DAHLIN-379
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-379
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>          Components: dahdi (the module)
>    Affects Versions: 3.1.0
>         Environment: Ubuntu 18.04.4 LTS with HWE kernel (5.4.0-42-generic)
>            Reporter: Gregory Massel
>            Assignee: Keith Morgan
>
> DAHDI 3.1.0 does not compile successfully against kernels 5.4.x:
> In file included from /root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi/oct612x/oct612x-user.c:28:0:
> /root/dahdi-linux-complete-3.1.0+3.1.0/linux/include/dahdi/kernel.h:62:10: fatal error: linux/pci-aspm.h: No such file or directory
>  #include <linux/pci-aspm.h>
>           ^~~~~~~~~~~~~~~~~~
> compilation terminated.
> scripts/Makefile.build:273: recipe for target '/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi/oct612x/oct612x-user.o' failed
> make[4]: *** [/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi/oct612x/oct612x-user.o] Error 1
> scripts/Makefile.build:522: recipe for target '/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi/oct612x' failed
> make[3]: *** [/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi/oct612x] Error 2
> Makefile:1731: recipe for target '/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi' failed
> make[2]: *** [/root/dahdi-linux-complete-3.1.0+3.1.0/linux/drivers/dahdi] Error 2
> make[2]: Leaving directory '/usr/src/linux-headers-5.4.0-42-generic'
> Makefile:74: recipe for target 'modules' failed
> make[1]: *** [modules] Error 2
> make[1]: Leaving directory '/root/dahdi-linux-complete-3.1.0+3.1.0/linux'
> Makefile:9: recipe for target 'all' failed
> make: *** [all] Error 2



--
This message was sent by Atlassian JIRA
(v6.2#6252)