[asterisk-bugs] [JIRA] (ASTERISK-29118) VoiceMail() should have an option to play greetings as Early Media

[Juan Carlos Castro y Castro (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=252475#comment-252475 ] 

Juan Carlos Castro y Castro commented on ASTERISK-29118:
--------------------------------------------------------

I've made some changes suggested by Sean, re-submitted successfully, but the cherripick gave me an error AGAIN. I did a "git commit --allow-empty" as it suggested and I got this output. Is this OK?

jcastro at pbx:~/src/asterisk-17-git$ git review --cherrypick 15065 18
Downloading refs/changes/65/15065/3 from gerrit
There was a problem applying changeset contents to the current branch.
The following command failed with exit code 1
    "git cherry-pick FETCH_HEAD"
-----------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch review/juan_carlos_castro_y_castro/ASTERISK-29118
Your branch and 'gerrit/17' have diverged,
and have 1 and 2 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

You are currently cherry-picking commit 5b012ed16e.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
-----------------------
jcastro at pbx:~/src/asterisk-17-git$ git commit --allow-empty
[review/juan_carlos_castro_y_castro/ASTERISK-29118 69c522050d] voicemail: add option 'e' top play greetings as early media
 Author: Joshua C. Colp <jcolp at sangoma.com>
 Date: Mon Oct 12 07:30:52 2020 -0300
jcastro at pbx:~/src/asterisk-17-git$

> VoiceMail() should have an option to play greetings as Early Media
> ------------------------------------------------------------------
>
>                 Key: ASTERISK-29118
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29118
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_voicemail/NewFeature
>    Affects Versions: 17.7.0
>            Reporter: Juan Carlos Castro y Castro
>            Assignee: Juan Carlos Castro y Castro
>            Severity: Minor
>              Labels: patch
>         Attachments: asterisk-voicemail-greetings-early-media-v2.patch
>
>
> It'd be nice if billsec in the CDR was zero if the person calling an unavailable endpoint, when executing VoiceMail(), hangs up before the “leave message” beep? That’s how cellphone operators here behave and I believe it's an useful feature.



--
This message was sent by Atlassian JIRA
(v6.2#6252)