[asterisk-bugs] [JIRA] (ASTERISK-29118) VoiceMail() should have an option to play greetings as Early Media
Juan Carlos Castro y Castro (JIRA)
noreply at issues.asterisk.org
Thu Oct 15 14:36:36 CDT 2020
[ https://issues.asterisk.org/jira/browse/ASTERISK-29118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=252434#comment-252434 ]
Juan Carlos Castro y Castro edited comment on ASTERISK-29118 at 10/15/20 2:36 PM:
----------------------------------------------------------------------------------
Ok, starting from scratch in another machine, Ubuntu 20.04, running as root. Apparently it did go through but it got "merged" (if that makes sense) with a previous commit from another author. When trying "git commit" without --amend it'd say there's no changes.
{{
jcastro at pbx:~$ cat >.ssh/config
Host asterisk
Hostname gerrit.asterisk.org
Port 29418
User jcastro
jcastro at pbx:~$ mkdir src
jcastro at pbx:~$ git clone -b 17 asterisk:asterisk asterisk-17-git
Cloning into 'asterisk-17-git'...
remote: Counting objects: 20918, done
remote: Finding sources: 100% (9464/9464)
remote: Total 345201 (delta 2122), reused 340585 (delta 2122)
Receiving objects: 100% (345201/345201), 206.87 MiB | 6.03 MiB/s, done.
Resolving deltas: 100% (260062/260062), done.
jcastro at pbx:~$ sudo apt-get -y install git-review
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
git-review
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 35.6 kB of archives.
After this operation, 161 kB of additional disk space will be used.
Get:1 http://br.archive.ubuntu.com/ubuntu focal/universe amd64 git-review all 1.27.0-1 [35.6 kB]
Fetched 35.6 kB in 0s (336 kB/s)
Selecting previously unselected package git-review.
(Reading database ... 142600 files and directories currently installed.)
Preparing to unpack .../git-review_1.27.0-1_all.deb ...
Unpacking git-review (1.27.0-1) ...
Setting up git-review (1.27.0-1) ...
Processing triggers for man-db (2.9.1-1) ...
jcastro at pbx:~$ git config --global --add user.email jccyc1965 at gmail.com
jcastro at pbx:~$ git config --global --add user.name "Juan Carlos Castro y Castro"
jcastro at pbx:~$ cd asterisk-17-git
jcastro at pbx:~/asterisk-17-git$ git checkout -b ASTERISK-29118
Switched to a new branch 'ASTERISK-29118'
jcastro at pbx:~/asterisk-17-git$ patch -p1 <~/asterisk-voicemail-greetings-early-media-v2.patch
patching file apps/app_voicemail.c
jcastro at pbx:~/asterisk-17-git$ git add apps/app_voicemail.c
jcastro at pbx:~/asterisk-17-git$ git commit
Aborting commit due to empty commit message.
jcastro at pbx:~/asterisk-17-git$ ls .git/hooks/
applypatch-msg.sample fsmonitor-watchman.sample pre-applypatch.sample pre-merge-commit.sample pre-push.sample pre-receive.sample
commit-msg.sample post-update.sample pre-commit.sample prepare-commit-msg.sample pre-rebase.sample update.sample
jcastro at pbx:~/asterisk-17-git$ scp -p -P 29418 jcastro at gerrit.asterisk.org:hooks/commit-msg ".git/hooks/"
commit-msg 100% 1790 12.2KB/s 00:00
jcastro at pbx:~/asterisk-17-git$ git commit --amend
[ASTERISK-29118 811ae7d2d5] asterisk: Add verbose message stating support status.
Author: Joshua C. Colp <jcolp at sangoma.com>
Date: Mon Oct 12 07:30:52 2020 -0300
2 files changed, 29 insertions(+), 5 deletions(-)
jcastro at pbx:~/asterisk-17-git$ git commit
On branch ASTERISK-29118
nothing to commit, working tree clean
jcastro at pbx:~/asterisk-17-git$ git review 17
Creating a git remote called 'gerrit' that maps to:
ssh://jcastro@gerrit.asterisk.org:29418/asterisk.git
remote:
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: refs: 1 (|)
remote: Processing changes: refs: 1, done
remote: commit 31b9226: warning: subject >50 characters; use shorter first paragraph
remote: commit 31b9226: Missing issue-id in commit message
remote: Commit 31b9226347bfcc0dee29b0dd1a1631996acaa15b not associated to any issue
remote:
remote: Hint: insert one or more issue-id anywhere in the commit message.
remote: Issue-ids are strings matching (ASTERISK-[0-9]+)
remote: and are pointing to existing tickets on its-jira Issue-Tracker
To ssh://gerrit.asterisk.org:29418/asterisk.git
! [remote rejected] HEAD -> refs/for/17%topic=ASTERISK-29118 (change https://gerrit.asterisk.org/c/asterisk/+/15052 closed)
error: failed to push some refs to 'ssh://jcastro@gerrit.asterisk.org:29418/asterisk.git'
}}
was (Author: jccyc):
Ok, starting from scratch in another machine, Ubuntu 20.04, running as root. Apparently it did go through but it got "merged" (if that makes sense) with a previous commit from another author. When trying "git commit" without --amend it'd say there's no changes.
{{monospaced}}
jcastro at pbx:~$ cat >.ssh/config
Host asterisk
Hostname gerrit.asterisk.org
Port 29418
User jcastro
jcastro at pbx:~$ mkdir src
jcastro at pbx:~$ git clone -b 17 asterisk:asterisk asterisk-17-git
Cloning into 'asterisk-17-git'...
remote: Counting objects: 20918, done
remote: Finding sources: 100% (9464/9464)
remote: Total 345201 (delta 2122), reused 340585 (delta 2122)
Receiving objects: 100% (345201/345201), 206.87 MiB | 6.03 MiB/s, done.
Resolving deltas: 100% (260062/260062), done.
jcastro at pbx:~$ sudo apt-get -y install git-review
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
git-review
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 35.6 kB of archives.
After this operation, 161 kB of additional disk space will be used.
Get:1 http://br.archive.ubuntu.com/ubuntu focal/universe amd64 git-review all 1.27.0-1 [35.6 kB]
Fetched 35.6 kB in 0s (336 kB/s)
Selecting previously unselected package git-review.
(Reading database ... 142600 files and directories currently installed.)
Preparing to unpack .../git-review_1.27.0-1_all.deb ...
Unpacking git-review (1.27.0-1) ...
Setting up git-review (1.27.0-1) ...
Processing triggers for man-db (2.9.1-1) ...
jcastro at pbx:~$ git config --global --add user.email jccyc1965 at gmail.com
jcastro at pbx:~$ git config --global --add user.name "Juan Carlos Castro y Castro"
jcastro at pbx:~$ cd asterisk-17-git
jcastro at pbx:~/asterisk-17-git$ git checkout -b ASTERISK-29118
Switched to a new branch 'ASTERISK-29118'
jcastro at pbx:~/asterisk-17-git$ patch -p1 <~/asterisk-voicemail-greetings-early-media-v2.patch
patching file apps/app_voicemail.c
jcastro at pbx:~/asterisk-17-git$ git add apps/app_voicemail.c
jcastro at pbx:~/asterisk-17-git$ git commit
Aborting commit due to empty commit message.
jcastro at pbx:~/asterisk-17-git$ ls .git/hooks/
applypatch-msg.sample fsmonitor-watchman.sample pre-applypatch.sample pre-merge-commit.sample pre-push.sample pre-receive.sample
commit-msg.sample post-update.sample pre-commit.sample prepare-commit-msg.sample pre-rebase.sample update.sample
jcastro at pbx:~/asterisk-17-git$ scp -p -P 29418 jcastro at gerrit.asterisk.org:hooks/commit-msg ".git/hooks/"
commit-msg 100% 1790 12.2KB/s 00:00
jcastro at pbx:~/asterisk-17-git$ git commit --amend
[ASTERISK-29118 811ae7d2d5] asterisk: Add verbose message stating support status.
Author: Joshua C. Colp <jcolp at sangoma.com>
Date: Mon Oct 12 07:30:52 2020 -0300
2 files changed, 29 insertions(+), 5 deletions(-)
jcastro at pbx:~/asterisk-17-git$ git commit
On branch ASTERISK-29118
nothing to commit, working tree clean
jcastro at pbx:~/asterisk-17-git$ git review 17
Creating a git remote called 'gerrit' that maps to:
ssh://jcastro@gerrit.asterisk.org:29418/asterisk.git
remote:
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: (/)
remote: Processing changes: (-)
remote: Processing changes: (\)
remote: Processing changes: (|)
remote: Processing changes: refs: 1 (|)
remote: Processing changes: refs: 1, done
remote: commit 31b9226: warning: subject >50 characters; use shorter first paragraph
remote: commit 31b9226: Missing issue-id in commit message
remote: Commit 31b9226347bfcc0dee29b0dd1a1631996acaa15b not associated to any issue
remote:
remote: Hint: insert one or more issue-id anywhere in the commit message.
remote: Issue-ids are strings matching (ASTERISK-[0-9]+)
remote: and are pointing to existing tickets on its-jira Issue-Tracker
To ssh://gerrit.asterisk.org:29418/asterisk.git
! [remote rejected] HEAD -> refs/for/17%topic=ASTERISK-29118 (change https://gerrit.asterisk.org/c/asterisk/+/15052 closed)
error: failed to push some refs to 'ssh://jcastro@gerrit.asterisk.org:29418/asterisk.git'
{{monospaced}}
> VoiceMail() should have an option to play greetings as Early Media
> ------------------------------------------------------------------
>
> Key: ASTERISK-29118
> URL: https://issues.asterisk.org/jira/browse/ASTERISK-29118
> Project: Asterisk
> Issue Type: Improvement
> Security Level: None
> Components: Applications/app_voicemail/NewFeature
> Affects Versions: 17.7.0
> Reporter: Juan Carlos Castro y Castro
> Assignee: Juan Carlos Castro y Castro
> Severity: Minor
> Labels: patch
> Attachments: asterisk-voicemail-greetings-early-media-v2.patch
>
>
> It'd be nice if billsec in the CDR was zero if the person calling an unavailable endpoint, when executing VoiceMail(), hangs up before the “leave message” beep? That’s how cellphone operators here behave and I believe it's an useful feature.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
More information about the asterisk-bugs
mailing list