[asterisk-bugs] [JIRA] (ASTERISK-28914) Websocket client doesn't use mask

[Nickolay V. Shmyrev (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nickolay V. Shmyrev updated ASTERISK-28914:
-------------------------------------------

    Attachment: asterisk-websocket-fix.diff

The following patch should fix the problem. I'm not yet approved on Gerrit to submit it.

> Websocket client doesn't use mask
> ---------------------------------
>
>                 Key: ASTERISK-28914
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28914
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_http_websocket
>    Affects Versions: GIT
>            Reporter: Nickolay V. Shmyrev
>            Severity: Minor
>              Labels: patch
>         Attachments: asterisk-websocket-fix.diff
>
>
> According to websocket protocol specification https://tools.ietf.org/html/rfc6455#section-5.1 websocket clients MUST use masking when sending data. However, current code doesn't use mask and thus can't work with some websocket servers (websockets python library for example).
> https://github.com/asterisk/asterisk/blob/master/res/res_http_websocket.c#L382
> At least dummy mask would be nice to have.
> See also
> https://stackoverflow.com/questions/33250207/why-are-websockets-masked



--
This message was sent by Atlassian JIRA
(v6.2#6252)