[asterisk-bugs] [JIRA] (ASTERISK-28890) KeepAlives don't work for video, but I have the fix.

[Luke Escude (JIRA)]

Luke Escude created ASTERISK-28890:
--------------------------------------

             Summary: KeepAlives don't work for video, but I have the fix.
                 Key: ASTERISK-28890
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28890
             Project: Asterisk
          Issue Type: Improvement
      Security Level: None
          Components: pjproject/pjsip
    Affects Versions: 17.4.0
            Reporter: Luke Escude
            Severity: Minor


So I've noticed that RTP Keepalives work just fine for audio, but they don't function for video.

Here are the changes needed to be made for keepalive packets to function for video:

In res/res_pjsip_sdp_rtp.c:

Change the following (Line 2032):

if (media_type != AST_MEDIA_TYPE_AUDIO) {

to: if (media_type != AST_MEDIA_TYPE_AUDIO && media_type != AST_MEDIA_TYPE_VIDEO) {

ALSO

Change the following (Line 2061):

if (session->endpoint->media.rtp.keepalive > 0 &&
			session_media->type == AST_MEDIA_TYPE_AUDIO) {

to

if (session->endpoint->media.rtp.keepalive > 0 &&
			(session_media->type == AST_MEDIA_TYPE_AUDIO || session_media->type == AST_MEDIA_TYPE_VIDEO)) {


Sorry guys, I don't know how to make a patch... But these 2 line changes will fix dysfunctional keepalives for video.



--
This message was sent by Atlassian JIRA
(v6.2#6252)