[asterisk-bugs] [JIRA] (ASTERISK-28792) codec_gsm: while building, optimization flag is overwritten

[Asterisk Team (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250046#comment-250046 ] 

Asterisk Team commented on ASTERISK-28792:
------------------------------------------

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].

Please note that once your issue enters an open state it has been accepted. As Asterisk is an open source project there is no guarantee or timeframe on when your issue will be looked into. If you need expedient resolution you will need to find and pay a suitable developer. Asking for an update on your issue will not yield any progress on it and will not result in a response. All updates are posted to the issue when they occur.

> codec_gsm: while building, optimization flag is overwritten
> -----------------------------------------------------------
>
>                 Key: ASTERISK-28792
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28792
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Codecs/codec_gsm
>    Affects Versions: 13.32.0, 16.9.0, 17.3.0
>            Reporter: Alexander Traud
>            Severity: Minor
>
> Because of ASTERISK-28374, I found this issue here.
> With the Compiler Flag DONT_OPTIMIZE is enabled, Clang erred while compiling the file {{codecs/gsm/src/add.c}}. This happens, because the {{Makefile}} in the directory {{codecs/gsm}} checks for a specific GCC version as well. That check works correctly. However, the variable name OPTIMIZE is re-used. Because of that, the value of OPTIMIZE from the default {{Makefile.rules}} is used (even when DONT_OPTIMIZE is enabled).
> Consequently, this is not a Clang specific issue but also affects GCC.
> The related issues reports are:
> * Mantis 17688 (now ASTERISK-16408)
> * Mantis 11243 (now ASTERISK-10762)
> * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=34216
> The easy fix would be to change the names of those two OPTIMIZE (and the hope that -O0 -O3 gets -O0). The correct fix would be to investigate that GCC -O3 issue finally and possibly remove that compiler switch completely. Not sure what to do. Therefore, I am just reporting this actual 13 year old software bug. Because ASTERISK-28374 is now fixed, the issue here is a no-care actually.



--
This message was sent by Atlassian JIRA
(v6.2#6252)