[asterisk-bugs] [JIRA] (DAHTOOL-85) dahdi-tools fails to build with -fno-common (enabled by default in gcc 10)

[Sean Bright (JIRA)]

     [ https://issues.asterisk.org/jira/browse/DAHTOOL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Bright updated DAHTOOL-85:
-------------------------------

    Description: 
https://bugs.gentoo.org/706832

I'll scope what's going on and submit a patch asap.

{noformat}
libtool: link: rm -fr .libs/libastribank.lax
libtool: link: ( cd ".libs" && rm -f "libastribank.la" && ln -s "../libastribank.la" "libastribank.la" )
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include  -Wall  -O2 -pipe -march=native -fno-common -lusb-1.0  -Wl,-O1 -Wl,--as-needed -o astribank_tool astribank_tool-astribank_tool.o libastribank.la -lpthread -lm 
libtool: link: x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include -Wall -O2 -pipe -march=native -fno-common -Wl,-O1 -o astribank_tool astribank_tool-astribank_tool.o  -Wl,--as-needed ./.libs/libastribank.a -lusb-1.0 -lpthread -lm
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./.libs/libastribank.a(libxtalk_la-xtalk_sync.o):(.bss+0x0): multiple definition of `members'; ./.libs/libastribank.a(libastribank_la-mpptalk.o):(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
{noformat}

Using grep these are the definitions:

./xpp/xtalk/xtalk_raw.c:} PACKED members;
./xpp/xtalk/xtalk_sync.c:} PACKED members;
./xpp/mpptalk.c:} PACKED members;

I can't find that these are used anywhere though ...

  was:
https://bugs.gentoo.org/706832

I'll scope what's going on and submit a patch asap.

libtool: link: rm -fr .libs/libastribank.lax
libtool: link: ( cd ".libs" && rm -f "libastribank.la" && ln -s "../libastribank.la" "libastribank.la" )
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include  -Wall  -O2 -pipe -march=native -fno-common -lusb-1.0  -Wl,-O1 -Wl,--as-needed -o astribank_tool astribank_tool-astribank_tool.o libastribank.la -lpthread -lm 
libtool: link: x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include -Wall -O2 -pipe -march=native -fno-common -Wl,-O1 -o astribank_tool astribank_tool-astribank_tool.o  -Wl,--as-needed ./.libs/libastribank.a -lusb-1.0 -lpthread -lm
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./.libs/libastribank.a(libxtalk_la-xtalk_sync.o):(.bss+0x0): multiple definition of `members'; ./.libs/libastribank.a(libastribank_la-mpptalk.o):(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status

Using grep these are the definitions:

./xpp/xtalk/xtalk_raw.c:} PACKED members;
./xpp/xtalk/xtalk_sync.c:} PACKED members;
./xpp/mpptalk.c:} PACKED members;

I can't find that these are used anywhere though ...


> dahdi-tools fails to build with -fno-common (enabled by default in gcc 10)
> --------------------------------------------------------------------------
>
>                 Key: DAHTOOL-85
>                 URL: https://issues.asterisk.org/jira/browse/DAHTOOL-85
>             Project: DAHDI-Tools
>          Issue Type: Bug
>      Security Level: None
>          Components: General
>    Affects Versions: 3.0.0
>         Environment: Gentoo Linux, gcc 10 (or -fno-common to older gcc)
>            Reporter: Jaco Kroon
>            Assignee: Keith Morgan
>            Severity: Minor
>              Labels: patch
>         Attachments: dahdi-tools-3.1.0-fno-common.patch
>
>
> https://bugs.gentoo.org/706832
> I'll scope what's going on and submit a patch asap.
> {noformat}
> libtool: link: rm -fr .libs/libastribank.lax
> libtool: link: ( cd ".libs" && rm -f "libastribank.la" && ln -s "../libastribank.la" "libastribank.la" )
> /bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include  -Wall  -O2 -pipe -march=native -fno-common -lusb-1.0  -Wl,-O1 -Wl,--as-needed -o astribank_tool astribank_tool-astribank_tool.o libastribank.la -lpthread -lm 
> libtool: link: x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include -Wall -O2 -pipe -march=native -fno-common -Wl,-O1 -o astribank_tool astribank_tool-astribank_tool.o  -Wl,--as-needed ./.libs/libastribank.a -lusb-1.0 -lpthread -lm
> /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./.libs/libastribank.a(libxtalk_la-xtalk_sync.o):(.bss+0x0): multiple definition of `members'; ./.libs/libastribank.a(libastribank_la-mpptalk.o):(.bss+0x0): first defined here
> collect2: error: ld returned 1 exit status
> {noformat}
> Using grep these are the definitions:
> ./xpp/xtalk/xtalk_raw.c:} PACKED members;
> ./xpp/xtalk/xtalk_sync.c:} PACKED members;
> ./xpp/mpptalk.c:} PACKED members;
> I can't find that these are used anywhere though ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)