[asterisk-bugs] [JIRA] (ASTERISK-28900) res_fax: Double frame free when gateway in use with off-nominal format usage

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251052#comment-251052 ] 

Friendly Automation commented on ASTERISK-28900:
------------------------------------------------

Change 14454 merged by Friendly Automation:
res_fax: Don't consume frames given to fax gateway on write.

[https://gerrit.asterisk.org/c/asterisk/+/14454|https://gerrit.asterisk.org/c/asterisk/+/14454]

> res_fax: Double frame free when gateway in use with off-nominal format usage
> ----------------------------------------------------------------------------
>
>                 Key: ASTERISK-28900
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28900
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_fax
>    Affects Versions: 16.10.0
>         Environment: Ubuntu 18.04.4 LTS, Asterisk 16.10.0, kernels 5.0.0-29-generic and 5.0.0-37-generic, Intel E5-1680 and E3-1271. No DAHDI.
>            Reporter: Gregory Massel
>            Assignee: Joshua C. Colp
>              Labels: fax, patch
>         Attachments: 2020-05-12 Call that crashed Asterisk - client leg.pcap, 2020-05-12 Call that crashed Asterisk - SBC leg.pcap, 2020-05-13 Call that crashed Asterisk - client leg.pcapng, 2020-05-13 Call that crashed Asterisk - SBC leg.pcapng, 2020-05-18 Yeastar call new firmware does NOT crash Asterisk - client leg.pcap, 2020-05-18 Yeastar call new firmware does NOT crash Asterisk - SBC leg.pcap, 2020-05-20 08h57 0153044300 to 0865545610 - client leg.pcap, 2020-05-20 08h57 0153044300 to 0865545610 - SBC leg.pcap, 2020-05-20 09h11 0153044300 to 0865545610 - client leg.pcap, 2020-05-20 09h11 0153044300 to 0865545610 - SBC leg.pcap, ASTERISK-28900-2.diff, ASTERISK-28900.diff, core-brief.txt, core-brief.txt, core-full.txt, core-full.txt, core-info.txt, core-info.txt, core-locks.txt, core-locks.txt, core-thread1.txt, core-thread1.txt, detailed-log.txt, ExtractedBacktraceDetails.txt
>
>
> When the T.38 gateway is enabled on two PJSIP endpoints [ set_var=FAXOPT(gateway)=yes,15 ] and the called endpoint initiates a T.38 re-INVITE and the calling endpoint does NOT support T.38, Asterisk tries to gateway between the audio (RTP) and UDPTL (T.38). In most instances, this works fine. However, when the calling party involves a Yeastar PBX device, the call will - every time, repeatedly - cause the Asterisk box performing the T.38 gatewaying to immediately deadlock and, shortly thereafter, Asterisk core dumps. 
> At present this is only happening if the calling device is a Yeastar PBX which seems to indicate that a corrupt, malformed or missing RTP frame generated by that device is what is crashing Asterisk.
> In many instances the core dump is zero bytes or the backtrace is largely unusable, however, I have managed to extract a few usable backtraces as well as packet captures of the calls that tigger the crash.



--
This message was sent by Atlassian JIRA
(v6.2#6252)