[asterisk-bugs] [JIRA] (ASTERISK-28921) Wrong return value check for fwrite when writing to pcap file

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250989#comment-250989 ] 

Friendly Automation commented on ASTERISK-28921:
------------------------------------------------

Change 14449 merged by Joshua Colp:
res_pjsip_logger.c: correct the return value checks when writing to pcap files

[https://gerrit.asterisk.org/c/asterisk/+/14449|https://gerrit.asterisk.org/c/asterisk/+/14449]

> Wrong return value check for fwrite when writing to pcap file
> -------------------------------------------------------------
>
>                 Key: ASTERISK-28921
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28921
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_pjsip_logger
>    Affects Versions: 16.11.0
>            Reporter: nappsoft
>            Assignee: nappsoft
>            Severity: Minor
>              Labels: patch
>         Attachments: correct_checks.diff
>
>
> When using the new feature that logs to pcap files one will get 5 lines with warnings for each packet written.
> This is because of the fact that the wrong return value is being checked: fwrite does not return the number of bytes written, but the number of elements written. However asterisk is comparing the return value (which will always be 1) with the size of the element, resulting in the following output:
> [May 29 07:22:23] WARNING[7274]: res_pjsip_logger.c:250 pjsip_logger_write_to_pcap: Writing PCAP header failed: Invalid argument
> [May 29 07:22:23] WARNING[7274]: res_pjsip_logger.c:253 pjsip_logger_write_to_pcap: Writing ethernet header to pcap failed: Invalid argument
> [May 29 07:22:23] WARNING[7274]: res_pjsip_logger.c:256 pjsip_logger_write_to_pcap: Writing IP header to pcap failed: Invalid argument
> [May 29 07:22:23] WARNING[7274]: res_pjsip_logger.c:259 pjsip_logger_write_to_pcap: Writing UDP header to pcap failed: Invalid argument
> [May 29 07:22:23] WARNING[7274]: res_pjsip_logger.c:262 pjsip_logger_write_to_pcap: Writing UDP payload to pcap failed: Invalid argument
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)