[asterisk-bugs] [JIRA] (ASTERISK-29008) Adding an XMPP component user does not approve subscription

[Stephen Paul Weber (JIRA)]

Stephen Paul Weber created ASTERISK-29008:
---------------------------------------------

             Summary: Adding an XMPP component user does not approve subscription
                 Key: ASTERISK-29008
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29008
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_xmpp
    Affects Versions: GIT
         Environment: debian stable
            Reporter: Stephen Paul Weber
            Severity: Minor


If you set res_xmpp to connect as a component at host `asterisk`, and then from an XMPP client you add a new contact `someone at asterisk` you will find that res_xmpp sends presence (so you know the user is "online") but does *not* approve the subscription.

Looking at the code in `xmpp_pak_s10n` one can see that the `subscribed` response is *always* send from the jid of the component no matter what is being subscribed to, while presence is correctly sent back from the jid being subscribed to.

{code:none}
diff --git a/res/res_xmpp.c b/res/res_xmpp.c
index 0f304375fe..e821babe80 100644
--- a/res/res_xmpp.c
+++ b/res/res_xmpp.c
@@ -3401,7 +3401,7 @@ static int xmpp_pak_s10n(struct ast_xmpp_client *client, struct ast_xmpp_client_
                        if ((presence = iks_new("presence")) && (status = iks_new("status"))) {
                                iks_insert_attrib(presence, "type", "subscribed");
                                iks_insert_attrib(presence, "to", pak->from->full);
-                               iks_insert_attrib(presence, "from", client->jid->full);
+                               iks_insert_attrib(presence, "from", pak->from->full);
 
                                if (pak->id) {
                                        iks_insert_attrib(presence, "id", pak->id);
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)