[asterisk-bugs] [JIRA] (ASTERISK-28638) Simplify dialplan for Dial, Page, and ChanIsAvail

[Richard Mudgett (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Mudgett updated ASTERISK-28638:
---------------------------------------

    Description: 
It is convenient to get back a dialable string from the PJSIP_DIAL_CONTACTS function so you can pass it in to Dial() right away. But if there are no contacts, then the string is empty, and therefore not dialable. (The channel will hang up.)

This patch does not change existing behaviour. It only returns 'PJSIP/endpoint' if you provide the 'please' argument:

{noformat}
Dial(${PJSIP_DIAL_CONTACTS(555,,,please)})
{noformat}

...will never let you down, even if 555 is not reachable, or if 555 is not a defined endpoint in your configuration.

Addition (Richard Mudgett):
Instead of changing PJSIP_DIAL_CONTACTS, I made patches to the Dial, Page, and ChanIsAvail applications to allow empty technology/resource positions in the list including the empty list.  Dialplan is now simplified for more cases than an empty PJSIP_DIAL_CONTACTS list.  Patches are up on Gerrit.

  was:
It is convenient to get back a dialable string from the PJSIP_DIAL_CONTACTS function so you can pass it in to Dial() right away. But if there are no contacts, then the string is empty, and therefore not dialable. (The channel will hang up.)

This patch does not change existing behaviour. It only returns 'PJSIP/endpoint' if you provide the 'please' argument:

{noformat}
Dial(${PJSIP_DIAL_CONTACTS(555,,,please)})
{noformat}

...will never let you down, even if 555 is not reachable, or if 555 is not a defined endpoint in your configuration.


> Simplify dialplan for Dial, Page, and ChanIsAvail
> -------------------------------------------------
>
>                 Key: ASTERISK-28638
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28638
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 13.29.1, 14.7.8, GIT, 15.7.3, 16.6.1, 17.0.0
>         Environment: Debian GNU/Linux
>            Reporter: cmaj
>            Assignee: cmaj
>            Severity: Minor
>              Labels: patch
>         Attachments: please_PJSIP_DIAL_CONTACTS.diff
>
>
> It is convenient to get back a dialable string from the PJSIP_DIAL_CONTACTS function so you can pass it in to Dial() right away. But if there are no contacts, then the string is empty, and therefore not dialable. (The channel will hang up.)
> This patch does not change existing behaviour. It only returns 'PJSIP/endpoint' if you provide the 'please' argument:
> {noformat}
> Dial(${PJSIP_DIAL_CONTACTS(555,,,please)})
> {noformat}
> ...will never let you down, even if 555 is not reachable, or if 555 is not a defined endpoint in your configuration.
> Addition (Richard Mudgett):
> Instead of changing PJSIP_DIAL_CONTACTS, I made patches to the Dial, Page, and ChanIsAvail applications to allow empty technology/resource positions in the list including the empty list.  Dialplan is now simplified for more cases than an empty PJSIP_DIAL_CONTACTS list.  Patches are up on Gerrit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)