[asterisk-bugs] [JIRA] (ASTERISK-28738) Incorrect state machine used when MOH_PASSTHRU is used

[Torrey Searle (JIRA)]

Torrey Searle created ASTERISK-28738:
----------------------------------------

             Summary: Incorrect state machine used when MOH_PASSTHRU is used
                 Key: ASTERISK-28738
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28738
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_pjsip_sdp_rtp
    Affects Versions: 13.20.0
            Reporter: Torrey Searle


When MOH_PASSTRHOUGH is active in a setup
A -> ASTERISK -> B

When A sends on-hold, asterisk sends an on-hold with "sendonly" to B

However if while the first hold is active and B wants to hold in the reverse direction, B sends "inactive", but asterisk incorrectly forwards this to A as "sendonly"

This is in violation of RFC3264 section 8.4 which says as follows:

   If the stream to be placed on hold was previously a sendrecv media
   stream, it is placed on hold by marking it as sendonly.  If the
   stream to be placed on hold was previously a recvonly media stream,
   it is placed on hold by marking it inactive.

Attached is a patch and a testsuite test that validates the on hold state machine is properly implemented



--
This message was sent by Atlassian JIRA
(v6.2#6252)