[asterisk-bugs] [JIRA] (ASTERISK-28720) When using realtime queues penaltymemberslimit checks for all members count

[Benjamin Keith Ford (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Keith Ford updated ASTERISK-28720:
-------------------------------------------

    Assignee: EDV O-TON  (was: Unassigned)
      Status: Waiting for Feedback  (was: Triage)

After looking at the code, I found this:
{code}
int membercount = ao2_container_count(q->members);
unsigned char usepenalty = (membercount <= q->penaltymemberslimit) ? 0 : 1;
{code}
which means that penaltymemberslimit is checking based off of the total number of members in the queue. Unfortunately, I saw no workaround in {{queues.conf}} or {{queuerules.conf}} for this, which means this would be a feature request. If you program and would like to submit a patch to Gerrit\[1], more information on how to do that can be found here\[2]. It would need to be backwards compatible (i.e. an option that defaults to "off"). If you are not a programmer, there are other ways to potentially get a patch in, including the {{asterisk-dev}} mailing list\[3] or submitting a bug bounty\[4].

\[1]: https://gerrit.asterisk.org/q/status:open
\[2]: https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
\[3]: https://wiki.asterisk.org/wiki/display/AST/Mailing+Lists
\[4]: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Bug+Bounties

> When using realtime queues penaltymemberslimit checks for all members count
> ---------------------------------------------------------------------------
>
>                 Key: ASTERISK-28720
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28720
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/Configuration
>    Affects Versions: 16.7.0
>         Environment: Ubuntu 18.04.3 with all latest patches until 29-01-2020
>            Reporter: EDV O-TON
>            Assignee: EDV O-TON
>            Severity: Minor
>
> The field penaltymemberslimit in the queue table should only check for valid members and not for all.
> Example: We have a queue with a max penalty of 50 and a penaltymemberslimit of 10. For this queue we have some fallback members with a penalty of 60. When there is NO member with a valid penalty of 50 but 10 fallback members with 60 I would expect, that the max penalty would be ignored but it isn't and no one gets a call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)