[asterisk-bugs] [JIRA] (ASTERISK-29184) memory leak manager.c:purge_old_stuff not scheduled when manager.conf enabled=no

[Diederik de Groot (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253156#comment-253156 ] 

Diederik de Groot commented on ASTERISK-29184:
----------------------------------------------

ast-16 is what i was hoping for ! Thanks for the heads up.
The ast_manager_check_enabled is a little inflexible and simple. But i do not think more is need in regard to this issue report. In most asterisk server setup's manager.conf is configured early on in the project and does not undergo changes often. Meaning manager_enabled is either on or off for the life time of the setup/instance.


> memory leak manager.c:purge_old_stuff not scheduled when manager.conf enabled=no
> --------------------------------------------------------------------------------
>
>                 Key: ASTERISK-29184
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29184
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/ManagerInterface
>    Affects Versions: GIT, 17.8.1, 18.0.1, 16.15.0
>         Environment: Any
>            Reporter: Diederik de Groot
>              Labels: ami, core, manager, memory-leak
>         Attachments: eventq.log
>
>
> With enabled=off in manager.conf the `purge_old_stuff` function from main/manager.c is never scheduled and doesn't run. Meaning that any time the append_event is called (for example through __manager_event_sessions_va / manager_event) new memory is allocated for the event, it is inserted in the `eventqent`, but never released. Causing a non negligible memory consumption over time. Enabling manager/ami and reloading resolves the memory leak.
> Possible/Potential Solutions: 
> - append_event could bail out early and not allocate memory.
> - purge_old_stuff could be scheduled even if ami/manager is not enabled.
> - purge_old_stuff could be scheduled on some other monitoring thread.



--
This message was sent by Atlassian JIRA
(v6.2#6252)