[asterisk-bugs] [JIRA] (ASTERISK-29176) Private REDIRECTING party ID data not used in PJSIP headers

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=252858#comment-252858 ] 

Kevin Harwell edited comment on ASTERISK-29176 at 12/1/20 9:12 AM:
-------------------------------------------------------------------

Yeah looks like just the from number info is checked and used:
{noformat}
	if (from->number.valid && !ast_strlen_zero(from->number.str)) {
		pj_strdup2(tdata->pool, &name_addr->display, from->name.str);
		pj_strdup2(tdata->pool, &uri->user, from->number.str);
	}
{noformat}
I think the fix should check if there is valid private info available then use it--, but only if {{trust_id_outbound}} has been set to "yes" too--. *edit*: see below, but might not need to check this option


was (Author: kharwell):
Yeah looks like just the from number info is checked and used:
{noformat}
	if (from->number.valid && !ast_strlen_zero(from->number.str)) {
		pj_strdup2(tdata->pool, &name_addr->display, from->name.str);
		pj_strdup2(tdata->pool, &uri->user, from->number.str);
	}
{noformat}
I think the fix should check if there is valid private info available then use it, but only if {{trust_id_outbound}} has been set to "yes" too.

> Private REDIRECTING party ID data not used in PJSIP headers
> -----------------------------------------------------------
>
>                 Key: ASTERISK-29176
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29176
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 16.15.0
>            Reporter: Kris Shaw
>            Assignee: Unassigned
>            Severity: Minor
>         Attachments: diversion-sip-trace.txt
>
>
> Unlike in chan_sip (and sig_pri), chan_pjsip does not take into account the priv* representations of the orig/from/to redirecting party IDs. When constructing the diversion and history headers via res_pjsip_diversion, the priv* values aren't merged with the standard party IDs to get the effective party IDs.
> Therefore, these headers may not be set as you might expect them to be from the documentation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)