[asterisk-bugs] [JIRA] (ASTERISK-29042) parker_uuid is no longer copied after a change in parking_bridge_features.c

[Misha Vodsedalek (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-29042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Misha Vodsedalek updated ASTERISK-29042:
----------------------------------------

    Description: 
A change introduced in Asterisk 13.35.0 eliminated a line that was copying parker_uuid into the subscription data structure.  Without the parker_uuid, the feature does not work correctly.

The specific change that introduced the problem:
@@ -189,8 +193,7 @@

        subscription_data->hangup_after = hangup_after;
        subscription_data->parkee_uuid = subscription_data->parker_uuid + parker_uuid_size;
 -       strcpy(subscription_data->parkee_uuid, parkee_uuid);
 -       strcpy(subscription_data->parker_uuid, parker_uuid);
 +       ast_copy_string(subscription_data->parkee_uuid, parkee_uuid, parkee_uuid_size);

        if (!(parked_datastore->parked_subscription = stasis_subscribe_pool(ast_parking_topic(), parker_update_cb, subscription_data))) {
                return -1;


  was:
A change introduced in Asterisk 13.35.0 eliminated a line that was copying parker_uuid into the subscription data structure.  Without the parker_uuid, the feature does not work correctly.

The specific change that introduced the problem:
@@ -189,8 +193,7 @@

        subscription_data->hangup_after = hangup_after;
        subscription_data->parkee_uuid = subscription_data->parker_uuid + parker_uuid_size;
-       strcpy(subscription_data->parkee_uuid, parkee_uuid);
-       strcpy(subscription_data->parker_uuid, parker_uuid);
+       ast_copy_string(subscription_data->parkee_uuid, parkee_uuid, parkee_uuid_size);

        if (!(parked_datastore->parked_subscription = stasis_subscribe_pool(ast_parking_topic(), parker_update_cb, subscription_data))) {
                return -1;



> parker_uuid is no longer copied after a change in parking_bridge_features.c
> ---------------------------------------------------------------------------
>
>                 Key: ASTERISK-29042
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29042
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_parking
>    Affects Versions: 13.35.0
>         Environment: Asterisk 13.35.0
>            Reporter: Misha Vodsedalek
>
> A change introduced in Asterisk 13.35.0 eliminated a line that was copying parker_uuid into the subscription data structure.  Without the parker_uuid, the feature does not work correctly.
> The specific change that introduced the problem:
> @@ -189,8 +193,7 @@
>         subscription_data->hangup_after = hangup_after;
>         subscription_data->parkee_uuid = subscription_data->parker_uuid + parker_uuid_size;
>  -       strcpy(subscription_data->parkee_uuid, parkee_uuid);
>  -       strcpy(subscription_data->parker_uuid, parker_uuid);
>  +       ast_copy_string(subscription_data->parkee_uuid, parkee_uuid, parkee_uuid_size);
>         if (!(parked_datastore->parked_subscription = stasis_subscribe_pool(ast_parking_topic(), parker_update_cb, subscription_data))) {
>                 return -1;



--
This message was sent by Atlassian JIRA
(v6.2#6252)