[asterisk-bugs] [JIRA] (ASTERISK-29029) Voicemail "pollmailboxes"-option not working, bug in function handle_subscribe

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-29029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251670#comment-251670 ] 

Kevin Harwell commented on ASTERISK-29029:
------------------------------------------

Many thanks for putting the patch up!

Usually most comments on a review are directed toward the patch creator (submitter/uploader). In this case however some are directed toward me. [~rmudgett] has found a couple of other problematic areas with the original "gcc" patch I had created. Those too should be fixed. You can either address, and fix all comments and re-upload the patch:

1) on the same branch with your current patch, fix the code based on the comments given
2) using git add and commit locally. Use 'git commit --amend' in order to apply the commit to the current commit.
3) then push to gerrit with git review again

Or if you just want to address comments about your patch only, and don't want to fix up the other items then leave those and I'll fix them up myself.

Hope that helps

> Voicemail "pollmailboxes"-option not working, bug in function handle_subscribe
> ------------------------------------------------------------------------------
>
>                 Key: ASTERISK-29029
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29029
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: 16.12.0
>            Reporter: Karsten Wemheuer
>            Assignee: Karsten Wemheuer
>              Labels: patch
>         Attachments: app_voicemail.c.diff
>
>
> After changing from 16.11 to 16.12 I noticed that the function "pollmailboxes" is no longer functional.
> During the search I found the error in function "handle_subscribe".



--
This message was sent by Atlassian JIRA
(v6.2#6252)