[asterisk-bugs] [JIRA] (ASTERISK-29021) [patch] Fix VERSION(ASTERISK_VERSION_NUM) on certified versions

Friendly Automation (JIRA) noreply at issues.asterisk.org
Fri Aug 14 14:50:43 CDT 2020


    [ https://issues.asterisk.org/jira/browse/ASTERISK-29021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251655#comment-251655 ] 

Friendly Automation commented on ASTERISK-29021:
------------------------------------------------

Change 14751 merged by Friendly Automation:
Makefile: Fix certified version numbers

[https://gerrit.asterisk.org/c/asterisk/+/14751|https://gerrit.asterisk.org/c/asterisk/+/14751]

> [patch] Fix VERSION(ASTERISK_VERSION_NUM) on certified versions
> ---------------------------------------------------------------
>
>                 Key: ASTERISK-29021
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-29021
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Functions/func_version
>    Affects Versions: 16.8.0
>            Reporter: cmaj
>            Assignee: cmaj
>            Severity: Minor
>
> The output of ${VERSION(ASTERISK_VERSION_NUM)} normally produces an integer of 6 digits, eg. Asterisk 16.8.0 produces 160800.
> There is corner case for git/svn pulls that should produce 999999, which makes sense (although 169999, 179999, 189999, etc. might make more sense.)
> Anyhow, certified versions fail to parse in reasonable manner; eg. Asterisk certified version 16.3-cert1 produces 00300, while both Asterisk certified versions 16.8-cert2 and 16.8-cert3 produce the same number 00800. This prevents dial plans from making adjustments on-the-fly to support earlier or later versions of Asterisk using different call flows.
> Pending patch adds a sed pipe before awk in Makefile to produce output like 160301, 160802, 160803, etc. The trade-off is potential conflict with non-certified versions if naming is not carefully considered, but none of the certified version 16's released so far would cause this problem because the naming is already being carefully considered (there is no 16.3.1, 16.8.2, or 16.8.3 in the non-certified releases.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)



More information about the asterisk-bugs mailing list