[asterisk-bugs] [JIRA] (ASTERISK-28840) samples: Missing for the modules cdr_ and cel_sqlite3_custom.

[Alexander Traud (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexander Traud updated ASTERISK-28840:
---------------------------------------

    Attachment: loader.patch
                sqlite3_custom.patch

{code}
cdr/cdr_sqlite3_custom.c
↳ load_module()
  ↳ load_config(0)
    ↳ if (!ast_variable_browse(cfg, "master")) {
{code}
That fails. There is a section ‘master’ in the file {{cdr_sqlite3_custom.conf.sample}} but that section is empty. I am not sure how to proceed from here. One trick (see the attached patch) would be to return not -1, not 0 but 1. Then, {{load_module}} could state: If the configuration file is empty, I do not proceed but load at least. However, then what about the subsequent code, is that executed in case of a reload: Some SQL statements and the module registering with its backend?

That was CDR. Same for CEL. As this is over my head, I have to leave the issue to someone else.

2. The next alternative, or a thing which should be done as well, would be to lower the log level of the loader itself, see the other attached patch.
3. The next alternative would be not to load those two via {{modules.conf.sample}} like it was done with {{res_hep_rtcp}}.

> samples: Missing for the modules cdr_ and cel_sqlite3_custom.
> -------------------------------------------------------------
>
>                 Key: ASTERISK-28840
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28840
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: CDR/cdr_sqlite3_custom, CEL/cel_sqlite3_custom, Configs/Samples
>    Affects Versions: 16.9.0, 17.3.0
>            Reporter: Alexander Traud
>            Assignee: Alexander Traud
>            Severity: Trivial
>              Labels: patch
>         Attachments: loader.patch, sqlite3_custom.patch
>
>
> On a minimal installation, after doing
> {{sudo make install config samples}}
> Asterisk gives:
> {code}
> WARNING: loader.c: load_modules: Some non-required modules failed to load.
> ERROR: loader.c: load_modules: cdr_sqlite3_custom declined to load.
> ERROR: loader.c: load_modules: cel_sqlite3_custom declined to load.
> Asterisk Ready.
> {code}
> I know that those ‘errors’ are trivial. However, a default, minimal installation cannot give errors. This confuses (a lot of) users, they cannot analyze/fix it themselves, and points them to the wrong cause for their actual issues. Therefore such wrong error message are expensive, especially in support.



--
This message was sent by Atlassian JIRA
(v6.2#6252)