[asterisk-bugs] [JIRA] (ASTERISK-28836) chan_oss: Video Console broken.

[Alexander Traud (JIRA)]

Alexander Traud created ASTERISK-28836:
------------------------------------------

             Summary: chan_oss: Video Console broken.
                 Key: ASTERISK-28836
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28836
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Channels/chan_oss
    Affects Versions: 17.3.0, 16.9.0, 13.32.0
            Reporter: Alexander Traud
            Severity: Minor


In the script configure, while going through all AST_EXT_LIB_SETUP, I find more and more code which is dead. That means, external projects are not used anymore too. This time, this is HAVE_FFMPEG, HAVE_SDL, HAVE_SDL_IMAGE, HAVE_VIDEODEV_H, and HAVE_X11.

That code is not maintained anymore since June 2008. It is guarded by the Define HAVE_VIDEO_CONSOLE. The project was ‘console_video’. It is used in the Console Channel Driver for the Open Sound System {{channels/chan_oss}}. That Define must be set manually, therefore this code slipped through all the years. In the year 2011, with GitHub-Commit [c26c190|https://github.com/asterisk/asterisk/commit/c26c190711a1bbe3b5fff1a93facae333757c56e] for Asterisk 10, it got disabled completely.

The problem is not so much the dead code. The problem is the script {{./configure}}. With every run, those libraries/headers are (tried to be) detected. Since Ubuntu 16.04 LTS (or even earlier) the following packages are involved:

- libavcodec-dev, fails because symbol moved to libswscale/swscale.h
- libavutil-dev, fails because Defines used but not included
- libswscale-dev, fails because header file moved
- libsdl1.2-dev, works
- libsdl-image1.2-dev, works
- libv4l-dev, fails because header file moved to libv4l1-videodev.h
- libx11-dev, works

This might confuse novice users who read the output of the script {{./configure}}: “Video, I want video. Why can’t I configure that? Why does it fail?” People waste time understanding and enabling this. Even after
- changing those two paths in the script configure and in the source,
- #define HAVE_VIDEO_CONSOLE not in chan_oss.c but in console_video.h,
- #include <libavutil/pixfmt.h> in channels/vgrabbers.c for PIX_FMT_,
still the code does not build. Too much changed in Asterisk and FFmpeg in the last 12 years.

I asked the original author Luigi Rizzo two years ago and he is not using that code anymore himself. Therefore, what about removing those parts within the script {{./configure}}, at least?



--
This message was sent by Atlassian JIRA
(v6.2#6252)