[asterisk-bugs] [JIRA] (ASTERISK-28826) res_rtp_asterisk: Duplicate seqnos being added to send buffer with NACK

[Joshua C. Colp (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250275#comment-250275 ] 

Joshua C. Colp commented on ASTERISK-28826:
-------------------------------------------

If it happens on the receive side then something is critically broken because the logic there already handles that case. We could be lenient in that case, but a contract has been broken in the implementation.

> res_rtp_asterisk: Duplicate seqnos being added to send buffer with NACK
> -----------------------------------------------------------------------
>
>                 Key: ASTERISK-28826
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28826
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 16.9.0
>            Reporter: nappsoft
>            Assignee: Unassigned
>              Labels: patch, webrtc
>         Attachments: patch1.diff
>
>
> When a packet is received twice (and though ast_data_buffer_put would report "Packet with position ... is already in buffer. Not inserting.") the payload will never be freed resulting in a memory leak.
> This behavior could be observerd with asterisk 16.9 during WebRTC conferences when some clients had bad connections and some packets needed to be repeated.
> Attached you'll find a patch that fixes the issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)