[asterisk-bugs] [JIRA] (ASTERISK-28826) memory leak in res_rtp_asterisk.c

[nappsoft (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250273#comment-250273 ] 

nappsoft commented on ASTERISK-28826:
-------------------------------------

Ah yes, you're right. Tbh: I am not even sure whether the mentioned output "Packet with position ... is already in buffer. Not inserting." was generated or not, it's just what I suspected as this seemed to be the only place in this function that made sense to not insert to packet.

However: the thing with MALLOC_DEBUG and the fact that the patch fixed the problem is true.

> memory leak in res_rtp_asterisk.c
> ---------------------------------
>
>                 Key: ASTERISK-28826
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28826
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_rtp_asterisk
>    Affects Versions: 16.9.0
>            Reporter: nappsoft
>            Assignee: Unassigned
>              Labels: patch, webrtc
>         Attachments: patch1.diff
>
>
> When a packet is received twice (and though ast_data_buffer_put would report "Packet with position ... is already in buffer. Not inserting.") the payload will never be freed resulting in a memory leak.
> This behavior could be observerd with asterisk 16.9 during WebRTC conferences when some clients had bad connections and some packets needed to be repeated.
> Attached you'll find a patch that fixes the issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)