[asterisk-bugs] [JIRA] (ASTERISK-28421) Wrong type used for timestamp in res_rtp_asterisk

[Morten Tryfoss (JIRA)]

Morten Tryfoss created ASTERISK-28421:
-----------------------------------------

             Summary: Wrong type used for timestamp in res_rtp_asterisk
                 Key: ASTERISK-28421
                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28421
             Project: Asterisk
          Issue Type: Bug
      Security Level: None
          Components: Resources/res_rtp_asterisk
    Affects Versions: 16.3.0
            Reporter: Morten Tryfoss
            Severity: Minor


int is used instead of unsigned int in ast_rtp_interpret. Values above max of an int causes (at least) the adaptive jitterbuffer to stop working because of negative timestamp value in the packet.

Suggested fix:

--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -6326,7 +6326,8 @@ static struct ast_frame *ast_rtp_interpret(struct ast_rtp_instance *instance, st
        unsigned int *rtpheader = (unsigned int*)(read_area);
        struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);
        struct ast_rtp_instance *instance1;
-       int res = length, hdrlen = 12, seqno, timestamp, payloadtype, padding, mark, ext, cc;
+       int res = length, hdrlen = 12, seqno, payloadtype, padding, mark, ext, cc;
+       unsigned int timestamp;
        RAII_VAR(struct ast_rtp_payload_type *, payload, NULL, ao2_cleanup);
        struct frame_list frames;
 




--
This message was sent by Atlassian JIRA
(v6.2#6252)