[asterisk-bugs] [JIRA] (ASTERISK-28311) ast_dsp_silence_noise_with_energy wrong judgment of frame format

[Benjamin Keith Ford (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246550#comment-246550 ] 

Benjamin Keith Ford commented on ASTERISK-28311:
------------------------------------------------

I think you are correct here, since AST_FORMAT_CMP_EQUAL evaluates to 0, so this would either need a "!", or the fix that you have suggested. Would you like to submit a patch on Gerrit [1] for this?

[1]: https://gerrit.asterisk.org

> ast_dsp_silence_noise_with_energy wrong judgment of frame format
> ----------------------------------------------------------------
>
>                 Key: ASTERISK-28311
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28311
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Core/General
>    Affects Versions: 16.2.0
>            Reporter: 周家建
>            Assignee: Unassigned
>            Severity: Minor
>
> In ast_dsp_silence_noise_with_energy function,failure to make a correct judgement on the return value of ast_format_cmp. This problem can lead to the energy of linear data does not match the energy of actual data.



--
This message was sent by Atlassian JIRA
(v6.2#6252)