[asterisk-bugs] [JIRA] (ASTERISK-28448) chan_sip: Sometimes G729 (without annexb=no) is negotiated

[Joshua C. Colp (JIRA)]

     [ https://issues.asterisk.org/jira/browse/ASTERISK-28448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua C. Colp updated ASTERISK-28448:
--------------------------------------

    Description: 
I noticed this issue when attempting to pass through G729 from a yealink to an upstream trunk using Cisco ENSR.

Asterisk was sometimes allowing VAD to be enabled, which is not supported as this is part of G729 ANNEX B. Call was made from yealink to cisco via asterisk. There was no annexb=no being sent. I tried this patch and the problem went away.

<removed inline patch>


  was:
I noticed this issue when attempting to pass through G729 from a yealink to an upstream trunk using Cisco ENSR.

Asterisk was sometimes allowing VAD to be enabled, which is not supported as this is part of G729 ANNEX B. Call was made from yealink to cisco via asterisk. There was no annexb=no being sent. I tried this patch and the problem went away.

--- a/channels/chan_sip.c	2019-05-30 17:26:01.000000000 +0000
+++ a/channels/chan_sip.c	2019-06-12 06:40:44.252898084 +0000
@@ -13191,6 +13191,9 @@
 	if (ast_format_cmp(format, ast_format_g723) == AST_FORMAT_CMP_EQUAL) {
 		/* Indicate that we don't support VAD (G.723.1 annex A) */
 		ast_str_append(a_buf, 0, "a=fmtp:%d annexa=no\r\n", rtp_code);
+	} else if (ast_format_cmp(format, ast_format_g729) == AST_FORMAT_CMP_EQUAL) {
+		/* Indicate that we don't support VAD (G.729.1 annex B) */
+		ast_str_append(a_buf, 0, "a=fmtp:%d annexb=no\r\n", rtp_code);
 	} else if (ast_format_cmp(format, ast_format_g719) == AST_FORMAT_CMP_EQUAL) {
 		/* Indicate that we only expect 64Kbps */
 		ast_str_append(a_buf, 0, "a=fmtp:%d bitrate=64000\r\n", rtp_code);



> chan_sip: Sometimes G729 (without annexb=no) is negotiated
> ----------------------------------------------------------
>
>                 Key: ASTERISK-28448
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28448
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Channels/chan_sip/CodecHandling
>    Affects Versions: 16.4.0
>         Environment: asterisk 16.4.0
> Yealink G729 -> asterisk -> Cisco ENSR3.0.6
>            Reporter: jim thom
>            Assignee: jim thom
>            Severity: Minor
>
> I noticed this issue when attempting to pass through G729 from a yealink to an upstream trunk using Cisco ENSR.
> Asterisk was sometimes allowing VAD to be enabled, which is not supported as this is part of G729 ANNEX B. Call was made from yealink to cisco via asterisk. There was no annexb=no being sent. I tried this patch and the problem went away.
> <removed inline patch>



--
This message was sent by Atlassian JIRA
(v6.2#6252)