[asterisk-bugs] [JIRA] (ASTERISK-28435) cdr_pgsql: Unix socket doesn't work

[Chris Savinovich (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=247351#comment-247351 ] 

Chris Savinovich commented on ASTERISK-28435:
---------------------------------------------

Hello Dmitry, sorry but the patch was merged to the release this morning.  While you are totally right when you say "no host no port" the end result of the current code is worst case scenario the connection string is syntactically valid. I would go back and make it better as per your suggestion but in the interest of responding to the other tickets I am going to leave as is. You are welcome to submit your own patch to Gerrit for review.  I want to suggest also, once code is up for review in Gerrit the best way to suggest a change to it is to participate in the review process, and add your positive or negative review to it. Works like a charm since it invites the opinion of all reviewers.
Thanks
Chris


> cdr_pgsql: Unix socket doesn't work
> -----------------------------------
>
>                 Key: ASTERISK-28435
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28435
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: CDR/cdr_pgsql
>    Affects Versions: 16.3.0
>            Reporter: Dmitry Svyatogorov
>            Assignee: Chris Savinovich
>
> After refactoring, function pgsql_reconnect() does "ast_str_set()" with statically composed string:
> {code}
> ast_str_set(&conn_info, 0, "host=%s port=%s dbname=%s user=%s"
> {code}
> It results in error while trying to connect to unix socket (empty host and port in config), so it's a regression.
> I propose the simple check:
> *<edit>*
> Editing to remove inline patch.
> Apologies, unfortunately inline patches are not allowed. Please see the patch contribution wiki [1] to learn more about contributing a patch to Asterisk, or attaching one here
> [1] https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process
> *<end edit>*
> This patch works for me. _But m.b. there is more clear way?_



--
This message was sent by Atlassian JIRA
(v6.2#6252)