[asterisk-bugs] [JIRA] (ASTERISK-28443) app_voicemail: remove dependency on stasis cache

[Friendly Automation (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=247585#comment-247585 ] 

Friendly Automation commented on ASTERISK-28443:
------------------------------------------------

Change 11466 merged by Kevin Harwell:
app_voicemail: Remove dependency on the stasis cache

[https://gerrit.asterisk.org/c/asterisk/+/11466|https://gerrit.asterisk.org/c/asterisk/+/11466]

> app_voicemail: remove dependency on stasis cache
> ------------------------------------------------
>
>                 Key: ASTERISK-28443
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28443
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Applications/app_voicemail
>    Affects Versions: GIT
>            Reporter: Kevin Harwell
>            Assignee: Kevin Harwell
>            Severity: Minor
>
> A while back the following two patches were put into Asterisk in order to [fix a memory leak|https://issues.asterisk.org/jira/browse/ASTERISK-27121], and improve performance (Note, all commit id's are against the 13 branch):
> [10132|https://gerrit.asterisk.org/c/asterisk/+/10132] ({{1843b0e}}) - Remove need to subscribe to stasis (app_voicemail)
> [10136|https://gerrit.asterisk.org/c/asterisk/+/10136] ({{94a4eea}}) - Stop caching stasis sub change msgs (stasis_cache)
> However, problems were reported ([ASTERISK-28151|https://issues.asterisk.org/jira/browse/ASTERISK-28151] && [ASTERISK-28222|https://issues.asterisk.org/jira/browse/ASTERISK-28222]) that made it so those patches needed to be reverted:
> [10718|https://gerrit.asterisk.org/c/asterisk/+/10718] ({{363d193}}) - Revert "app_voicemail: Remove need to subscribe to stasis"
> [10833|https://gerrit.asterisk.org/c/asterisk/+/10833] ({{96f8b19}}) - Revert "stasis_cache: Stop caching stasis subscription change messages"
> A [patch|https://gerrit.asterisk.org/c/asterisk/+/10799] ({{d0eccac}}) was made that fixed the FreePBX issue, but other valid concerns [were raised|https://issues.asterisk.org/jira/browse/ASTERISK-28151?focusedCommentId=245614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-245614] making it so those two patches could not simply be merged back into the code base. 
> This task is to figure out a way to get similar functionality in order to regain the significant performance improvement that was observed when removing the stasis cache from app_voicemail. This, of course will entail finding a way to remove the stasis cache from app_voicemail most likely by creating a subscribed mailbox "store" in the core. Also fixing the memory leak on the [original issue|https://issues.asterisk.org/jira/browse/ASTERISK-27121] would be entailed in this.
> API changes and/or additions will probably need to be made. If possible it'd be good to get this into all currently supported branches, but if need be it can be master only.



--
This message was sent by Atlassian JIRA
(v6.2#6252)