[asterisk-bugs] [JIRA] (ASTERISK-28660) res_fax: wrap Asterisk initiated negotiation with config option

[Kevin Harwell (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249059#comment-249059 ] 

Kevin Harwell commented on ASTERISK-28660:
------------------------------------------

[~alexei gradinari] Wasn't sure the best way for you to see this change, so pinging you here and added you as a reviewer on the review (https://gerrit.asterisk.org/c/asterisk/+/13443)

Just wanted to make you aware we've had to wrap your previous res_fax patch in a configuration option. You'll need to set "negotiate_both" to "yes" now in order for your patch to send out both negotiation requests.

Also any testing and/or feedback on the review you can give would be much appreciated.

Thanks!

> res_fax: wrap Asterisk initiated negotiation with config option
> ---------------------------------------------------------------
>
>                 Key: ASTERISK-28660
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28660
>             Project: Asterisk
>          Issue Type: Bug
>      Security Level: None
>          Components: Resources/res_fax
>    Affects Versions: 13.29.1, 16.6.1, 17.0.1
>            Reporter: Kevin Harwell
>              Labels: fax
>
> A previous patch:
> Gerrit Change-Id: I73bb24799bfe1a48adae9c034a2edbae54cc2a39
> Made it so a T.38 Gateway tries to negotiate with both sides by sending T.38 negotiation request to both endpoints supported T.38 versus the previous behavior of forwarding negotiation to the "other" channel once a preamble was detected.
> This had the unfortunate side effect of breaking some setups. Specifically ones that set the max datagram option on an endpoint configuration (configured max datagram was not propagated since Asterisk now initiates negotiations).
> Make it so this patched functionality is itself wrapped in an option, so the use case happens for it only in those setups requiring it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)