[asterisk-bugs] [JIRA] (ASTERISK-28638) [patch] Adds 'please' argument to PJSIP_DIAL_CONTACTS function

[cmaj (JIRA)]

    [ https://issues.asterisk.org/jira/browse/ASTERISK-28638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248949#comment-248949 ] 

cmaj edited comment on ASTERISK-28638 at 12/3/19 3:52 PM:
----------------------------------------------------------

Thanks, seems to work now with git-review version 1.27.0 on Debian 10!

New version of git-review reported:

{noformat}
remote: ERROR: commit 3b8a6ca: subject >80 characters; use shorter first paragraph
{noformat}

And also:

{noformat}
To ssh://gerrit.asterisk.org:29418/asterisk.git
 ! [remote rejected]       HEAD -> refs/for/13%topic=ASTERISK-28638 (commit 3b8a6ca: Commit length validation failed)
{noformat}

Much more helpful!


was (Author: cmaj):
Thanks, seems to work now with git-review version 1.27.0 on Debian 10!

New version of git-review reported:

{noformat}
remote: ERROR: commit 3b8a6ca: subject >80 characters; use shorter first paragraph
{noformat}

And also.

{noformat}
To ssh://gerrit.asterisk.org:29418/asterisk.git
 ! [remote rejected]       HEAD -> refs/for/13%topic=ASTERISK-28638 (commit 3b8a6ca: Commit length validation failed)
{noformat}

Much more helpful!

> [patch] Adds 'please' argument to PJSIP_DIAL_CONTACTS function
> --------------------------------------------------------------
>
>                 Key: ASTERISK-28638
>                 URL: https://issues.asterisk.org/jira/browse/ASTERISK-28638
>             Project: Asterisk
>          Issue Type: Improvement
>      Security Level: None
>          Components: Channels/chan_pjsip
>    Affects Versions: 13.29.1, 14.7.8, GIT, 15.7.3, 16.6.1, 17.0.0
>         Environment: Debian GNU/Linux
>            Reporter: cmaj
>            Assignee: Unassigned
>            Severity: Minor
>              Labels: patch
>         Attachments: please_PJSIP_DIAL_CONTACTS.diff
>
>
> It is convenient to get back a dialable string from the PJSIP_DIAL_CONTACTS function so you can pass it in to Dial() right away. But if there are no contacts, then the string is empty, and therefore not dialable. (The channel will hang up.)
> This patch does not change existing behaviour. It only returns 'PJSIP/endpoint' if you provide the 'please' argument:
> {noformat}
> Dial(${PJSIP_DIAL_CONTACTS(555,,,please)})
> {noformat}
> ...will never let you down, even if 555 is not reachable, or if 555 is not a defined endpoint in your configuration.



--
This message was sent by Atlassian JIRA
(v6.2#6252)