[asterisk-bugs] [JIRA] (DAHLIN-368) DAHDI fails to build against kernel 5.0

[Alex Regan (JIRA)]

    [ https://issues.asterisk.org/jira/browse/DAHLIN-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=247019#comment-247019 ] 

Alex Regan edited comment on DAHLIN-368 at 4/26/19 9:53 AM:
------------------------------------------------------------

Yes, this is absolutely the your branch. This is what I see near those lines:

<code>
    31  UINT32 Oct6100UserGetTime(tPOCT6100_GET_TIME f_pTime)
    32  {
    33          /* Why couldn't they just take a timeval like everyone else? */
    34          struct timeval tv;
    35          unsigned long long total_usecs;
    36          unsigned int mask = ~0;
    37  
    38          do_gettimeofday(&tv);
    39          total_usecs = (((unsigned long long)(tv.tv_sec)) * 1000000) +
    40                                    (((unsigned long long)(tv.tv_usec)));
    41          f_pTime->aulWallTimeUs[0] = (total_usecs & mask);
    42          f_pTime->aulWallTimeUs[1] = (total_usecs >> 32);
    43          return cOCT6100_ERR_OK;
    44  }</code>


was (Author: gossamer):
Yes, this is absolutely the your branch. This is what I see near those lines:

    31  UINT32 Oct6100UserGetTime(tPOCT6100_GET_TIME f_pTime)
    32  {
    33          /* Why couldn't they just take a timeval like everyone else? */
    34          struct timeval tv;
    35          unsigned long long total_usecs;
    36          unsigned int mask = ~0;
    37  
    38          do_gettimeofday(&tv);
    39          total_usecs = (((unsigned long long)(tv.tv_sec)) * 1000000) +
    40                                    (((unsigned long long)(tv.tv_usec)));
    41          f_pTime->aulWallTimeUs[0] = (total_usecs & mask);
    42          f_pTime->aulWallTimeUs[1] = (total_usecs >> 32);
    43          return cOCT6100_ERR_OK;
    44  }

> DAHDI fails to build against kernel 5.0
> ---------------------------------------
>
>                 Key: DAHLIN-368
>                 URL: https://issues.asterisk.org/jira/browse/DAHLIN-368
>             Project: DAHDI-Linux
>          Issue Type: Bug
>      Security Level: None
>          Components: dahdi (the module)
>    Affects Versions: 3.0.0
>            Reporter: Shaun Ruffell
>            Assignee: Keith Morgan
>
> Linux kernel 5.0 has changed the timekeeping interfaces to fix the 2038 problem.
> I believe the drivers should be standardized on ktime for internal time, but before making any changes to the app drivers, I was looking for some early feedback on the proposed approach.
> The work is currently at http://git.asterisk.org/gitweb/?p=team/sruffell/dahdi-linux.git;a=shortlog;h=refs/heads/for-5.0 if anyone has any comments.



--
This message was sent by Atlassian JIRA
(v6.2#6252)